This repository has been archived by the owner on Sep 15, 2023. It is now read-only.
Use rev'd asset urls in Twig and Handlebars files #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sks to generate correct asset URIs when the main `dest` is different from the final public folder.
# Conflicts: # gulpfile.js/tasks/rev/rev-assets.js
# Conflicts: # README.md # package.json # yarn.lock
|
Replaced by PR #513 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current the Rev task only replaces asset urls with their hashed counterparts in .html files. This expands that behavior to include .twig and .hbs files. (I suppose other common template files could be included as well – .php would be a good candidate for WordPress templates, etc.)