Skip to content
This repository has been archived by the owner on Sep 15, 2023. It is now read-only.

Descriptions are more tech-agnostic, and yarn syntax is up-to-date #574

Merged
merged 4 commits into from
Apr 19, 2019

Conversation

olets
Copy link
Contributor

@olets olets commented Mar 11, 2019

  1. Drops all mentions of gulp-starter, including in the logo and correcting some link paths.
  2. Tell users to use commands like
    yarn run blendid init
    as opposed to
    yarn run blendid -- init

@olets olets changed the base branch from master to develop March 11, 2019 23:19
@olets olets requested a review from benjtinsley March 11, 2019 23:19
Copy link

@leobauza leobauza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also wrong person to approve this since I don't use blendid but had a couple of q's and suggestions

README.md Outdated Show resolved Hide resolved
@@ -1,17 +1,17 @@
# Gulp Starter on Rails
# Blendid on Rails

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this section mention that it's probably a good idea to use webpacker instead of this, now that webpacker exists?

Copy link
Contributor Author

@olets olets Mar 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm keeping this PR narrowly focused on the word "gulp" and the "--", but yes there's definitely room for future improvement

@@ -1,7 +1,7 @@
{
"name": "blendid",
"version": "4.4.2",
"description": "(formerly gulp-starter) A full featured configurable gulp asset pipeline and static site builder",
"description": "A full featured configurable asset pipeline and static site builder",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

curious about the removal of gulp...it's still using gulp

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This whole PR is picking up a decision the whole team landed on quite a while back. Idea is remove language that ties Blendid to any specific tech, so that the tool can evolve more easily. Back in the early gulp-starter days the word "Gulp" itself was a badge of using the hot newness; now what matters is the functionality

@olets olets changed the title Documentation updates Documentation updates: descriptions are more tech-agnostic, and yarn syntax is up-to-date Mar 12, 2019
@olets olets changed the title Documentation updates: descriptions are more tech-agnostic, and yarn syntax is up-to-date Descriptions are more tech-agnostic, and yarn syntax is up-to-date Mar 12, 2019
@olets olets requested a review from ten1seven March 21, 2019 17:55
Copy link

@ten1seven ten1seven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@@ -3,7 +3,7 @@
[![Build Status](https://travis-ci.org/vigetlabs/blendid.svg?branch=static-server)](https://travis-ci.org/vigetlabs/blendid)
[![Stories in Ready](https://badge.waffle.io/vigetlabs/blendid.png?label=ready&title=Ready)](https://waffle.io/vigetlabs/blendid)

**Blendid** is a delicious stand-alone blend of tasks and build tools combined to form a full-featured modern asset pipeline. It can be used as-is as a static site builder, or can be configured and integrated into your own development environment and site or app structure.
**Blendid** is a delicious stand-alone blend of tasks and build tools poured together as a full-featured modern asset pipeline. It can be used as-is as a static site builder, or can be configured and integrated into your own development environment and site or app structure.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

funny, looking at that diff I thought the whole reason I changed it was to remove a gulp reference :head-scratch:

@olets olets merged commit bd22e26 into develop Apr 19, 2019
@olets olets deleted the documentation-updates branch May 28, 2019 18:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants