Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Social links #61

Closed
lsolesen opened this issue Jun 3, 2015 · 9 comments
Closed

Social links #61

lsolesen opened this issue Jun 3, 2015 · 9 comments
Assignees

Comments

@lsolesen
Copy link
Member

lsolesen commented Jun 3, 2015

I've created the social links block on vih.dk manually just through WYSIWYG editor. However it keeps breaking - and right now the size exploded.

Will the best way just be to create a block programatically or what do you say?

@lsolesen
Copy link
Member Author

lsolesen commented Jun 9, 2015

There is a snippet here, that might solve this: https://gist.github.com/lsolesen/8e38ebbc7201d8f8378e

And there is some work I started a while ago here: https://github.com/vih/vih_plugins/tree/social-links

I need to get vih.dk footer to look with nicer social media. I am thinking this approach is sound. I like how the links looks on glamanate.com. @mglaman Could you make it work :)

mglaman added a commit to vih/vih_plugins that referenced this issue Sep 24, 2015
@mglaman
Copy link
Contributor

mglaman commented Sep 24, 2015

screenshot from 2015-09-23 22 20 53

Here's a screenshot preview of what it looks like now if placed. Links need some coloring. I would recommend replacing footer with a mini panel and dropping in panes that way. But this should be good to go. Can merge branch in if you'd like, or if you want to, or if any immediate feedback.

@lsolesen
Copy link
Member Author

It would be cool with replacing the footer with something, so it is possible to drop in panes. Maybe also the right sidebar, it would be nice.

@mglaman
Copy link
Contributor

mglaman commented Sep 24, 2015

Using a mini panel as my block that goes in the footer has been my go to solution for a while. Let me know if you have a preference to a module to export it to, or if you plan on making a new one such as "vih_footer".

Can export it like you have now plus the new social links

@lsolesen
Copy link
Member Author

Whatever you think will be the best option. Thanks!

@mglaman
Copy link
Contributor

mglaman commented Sep 24, 2015

Hm. I think it might make sense to just make a new repo called vih_footer. If you spin that up and grant me access I will merge the social-links branch in on vih_plugins and export the footer mini panel with that pane and mimic existing footer.

Then you'll just need to swap out the blocks in production for the mini panel block

@lsolesen
Copy link
Member Author

Here: https://github.com/vih/vih_footer

mglaman added a commit that referenced this issue Sep 29, 2015
@mglaman
Copy link
Contributor

mglaman commented Sep 29, 2015

@lsolesen I guess I don't have access to push on vih_deploy! Have an update hook to enable vih_footer. I noticed the theme's footer is set to 3, 7, 2. In order for this to work I'll need to change one of them to col-md-12 so that the Panels layout can work it's magic. That OK?

@lsolesen
Copy link
Member Author

@mglaman Access granted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants