Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Userscript is consistently causing SE's JS to not load properly #124

Closed
Mego opened this issue Jun 14, 2017 · 13 comments
Closed

Userscript is consistently causing SE's JS to not load properly #124

Mego opened this issue Jun 14, 2017 · 13 comments
Labels

Comments

@Mego
Copy link
Contributor

Mego commented Jun 14, 2017

It takes 2-3 refreshes in order to comment, vote, or do anything else that relies on SE's JS code. This issue does not exist without the userscript.

@JJ-Atkinson
Copy link
Collaborator

I don't see this happening... Did it start with a specific update? Which browser are you using?

@somebody1234
Copy link
Contributor

It's been happening to me for a few months as well, using Chromium 58 at the moment

@RikerW
Copy link
Collaborator

RikerW commented Jun 14, 2017

Same here, but it doesn't fix itself when I turn off the userscript.

@vihanb vihanb added the bug label Jun 14, 2017
@vihanb
Copy link
Owner

vihanb commented Jun 14, 2017

Must be either innerhtml bork or tamprermonkey bork

@somebody1234
Copy link
Contributor

:| Who is using innerHTML

@somebody1234
Copy link
Contributor

@RikerW Maybe it's caused by SOX then? (if you have it)

@vihanb
Copy link
Owner

vihanb commented Jun 14, 2017

we're using document.head.innerHTML +=, that will invalidate the existing DOM head, so the scripts might not get correctly reloaded

@Mego
Copy link
Contributor Author

Mego commented Jun 14, 2017 via email

@somebody1234
Copy link
Contributor

@vihanb Oh no who did this I will report to w3c bad practice department :P

@vihanb
Copy link
Owner

vihanb commented Jun 15, 2017

ok with the removing of the innerHTMLs seems to work :D

@somebody1234
Copy link
Contributor

@Mego Can you try now?

@Mego
Copy link
Contributor Author

Mego commented Jun 15, 2017

@somebody1234 The issue doesn't seem to be happening anymore. Thanks!

@Mego Mego closed this as completed Jun 15, 2017
@somebody1234
Copy link
Contributor

@Mego I'm not exactly sure about that, I think it happened to me a few times after I fixed it (although it might be another userscript) so you might want to watch out just in case it happens again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants