Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draw all graphics (icons) programatically #6

Closed
dominik-hadl opened this issue Jul 1, 2014 · 7 comments
Closed

Draw all graphics (icons) programatically #6

dominik-hadl opened this issue Jul 1, 2014 · 7 comments

Comments

@dominik-hadl
Copy link
Contributor

I've noticed you use .xcassets containing all the graphic files related to the alert view. However, you could make it much more easier (and faster) if all the graphics were drawn using code. Have a look at PaintCode, they have just released an update which can generate Swift code.

If you are interested, I can make the changes and then create the pull request. If you have the original vector files, that would make it even easier.

@vikmeup
Copy link
Owner

vikmeup commented Jul 1, 2014

@sherzodmax, could you provide .ai assets of icons to @NickSkull, please.

@sherzodmax
Copy link

Alright, I'm on it. @NickSkull - can you please provide your email?
Or send it to mine: sherzoduix@gmail.com
I will send you the .ai files.

@dominik-hadl
Copy link
Contributor Author

Just sent you an email.

@vikmeup
Copy link
Owner

vikmeup commented Jul 9, 2014

@NickSkull any progress ?

@dominik-hadl
Copy link
Contributor Author

Sorry guys, had some work to do. I've opened a pull request with the new icons. Please, check it out.

@vikmeup
Copy link
Owner

vikmeup commented Jul 10, 2014

@NickSkull Thanks. I will take a look tonight

@sherzodmax
Copy link

I've looked at the icons, they're seem to be fine. Good job, thank you @NickSkull.

vikmeup added a commit that referenced this issue Jul 23, 2014
All icons now drawn programatically, fixes #6
PGMY pushed a commit to PGMY/SCLAlertView-Swift that referenced this issue Nov 5, 2014
PGMY pushed a commit to PGMY/SCLAlertView-Swift that referenced this issue Nov 5, 2014
All icons now drawn programatically, fixes vikmeup#6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants