feat: ✨ adds support for equal sign in keys

vilarfg · Apr 28, 2020 · 0959875 · 0959875
1 parent 68507f3
commit 0959875
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 2 deletions.
diff --git a/index.ts b/index.ts
@@ -51,11 +51,15 @@ export function encode(query: Query): string {
   for (const k in query) {
     const values = query[k];
     if (values) {
-      if (values === true) parts.push(k);
+      if (values === true) parts.push(k.replace(/=/g, "%3D"));
       else if (values.length) {
+        const safeKey = k.replace(/=/g, "%3D");
         let qsValue = "";
         for (let i = 0; i < values.length; i++)
-          qsValue += (i ? "&" : "") + k + "=" + values[i].replace(/\&/g, "%26");
+          qsValue = `${qsValue}${i ? "&" : ""}${safeKey}=${values[i].replace(
+            /&/g,
+            "%26",
+          )}`;
         parts.push(qsValue);
       }
     }

diff --git a/test/index.test.ts b/test/index.test.ts
@@ -49,6 +49,10 @@ describe("exported `decode`", () => {
         limit: ["20"],
       },
     ],
+    [
+      "?a%3Da=a&%3D=a=a&a%3D==&a%3D=",
+      { "a=a": ["a"], "=": ["a=a"], "a=": ["=", ""] },
+    ],
     [
       "?string=question&boolean&string=&string=42",
       { boolean: true, string: ["question", "", "42"] },
@@ -111,6 +115,10 @@ describe("exported `encode`", () => {
         limit: ["20"],
       },
     ],
+    [
+      "?%3D=a=a&a%3D==&a%3D=&a%3Da=a",
+      { "a=a": ["a"], "=": ["a=a"], "a=": ["=", ""] },
+    ],
     [
       "?boolean&string=question&string=&string=42",
       { boolean: true, string: ["question", "", "42"] },