Runtime error and memory leak bug fixes #8
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
ensure the web worker is terminated before deleting the reference to them so that the thread is destroyed and memory is release straight away.
ensures a job is not created where the block height is 0, and fixes the code that detects when one there's no job for a core.
OACDesigns
force-pushed
the
fix-worker-termination
branch
from
1ce29d1
to
d027eeb
Compare
|
i will merge, but before that i need to automate building. Will try to do that in next few days. |
|
👍 |
|
i added auto build, formatted code, merged you updates manually. status: merge manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two bugs:
it ensures the web workers are properly terminated before the reference to them is deleted.
If this isn't done, then the threads stay alive consuming resources, and in some cases this memory leak can crash the browser.
it fixes a bug where a web worker can end up having have a job where the block height is 0, causing a runtime error when drawing to the canvas context.
In addition to the above, unnecessary trailing white space has been removed (an automatic feature of my IDE)