🐛 Fix timing of DenopsPluginPost
#312
Conversation
WalkthroughThe modifications in Changes
Assessment against linked issues
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #312 +/- ##
=======================================
Coverage 96.47% 96.47%
=======================================
Files 3 3
Lines 85 85
Branches 6 6
=======================================
Hits 82 82
Misses 3 3 ☔ View full report in Codecov by Sentry. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- autoload/denops/plugin.vim (2 hunks)
Additional comments: 4
autoload/denops/plugin.vim (4)
149-158: The changes to
s:DenopsSystemPluginPostfunction seem to address the issue by setting the plugin as loaded before executing the callbacks and triggering theDenopsPluginPostevent. This should ensure thatdenops#plugin#is_loaded()returns the correct value when called from theDenopsPluginPostevent.174-174: The addition of the
++nestedflag to the autocmd forDenopsSystemPluginPost:*is a critical change that ensures the autocmds withins:DenopsSystemPluginPostare executed in a nested context, which is necessary for the correct order of event processing.146-162: > Note: This review was outside the patches, so it was mapped to the patch with the greatest overlap. Original lines [149-174]
The removal of
s:DenopsPluginPostfunction is not directly shown in the provided code, but the changes suggest that it has been replaced by the direct invocation ofs:DenopsSystemPluginPost. It is important to ensure that there are no remaining references tos:DenopsPluginPostelsewhere in the codebase.Verification successful
The executed script did not find any references to
s:DenopsPluginPostin the codebase, which aligns with the intended changes mentioned in the PR objectives and the AI-generated summary. This suggests that the function has been successfully removed without leaving any orphaned references.* 146-162: > Note: This review was outside the patches, so it was mapped to the patch with the greatest overlap. Original lines [1-158]Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Search for any remaining references to 's:DenopsPluginPost' which should have been removed. rg --type vim 's:DenopsPluginPost'Length of output: 34
The rest of the file appears to be unchanged. However, it's important to ensure that the changes made do not indirectly affect the behavior of the existing functions, especially those that might rely on the plugin loading state.
Close #311
Summary by CodeRabbit