-
-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
💪 Use type alias instead of comments #339
Conversation
It seems the latest deno fmt try to format the comments like from /home/runner/work/denops.vim/denops.vim/denops/@denops-private/host.ts: 57 | - success: string, // Callback ID 57 | + success: string // Callback ID 58 | - failure: string, // Callback ID 58 | + , 59 | + failure: string // Callback ID 59 | - ): Promise<void>; 60 | + , 61 | + ): Promise<void>; But the comment was mainly for documentation, so it is better to use type alias instead of comments.
WalkthroughThe recent update in the codebase introduces a new type Changes
Recent Review DetailsConfiguration used: CodeRabbit UI Files selected for processing (1)
Additional comments not posted (2)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #339 +/- ##
=======================================
Coverage 89.81% 89.81%
=======================================
Files 9 9
Lines 648 648
Branches 61 61
=======================================
Hits 582 582
Misses 66 66 ☔ View full report in Codecov by Sentry. |
It seems the latest deno fmt try to format the comments like
But the comment was mainly for documentation, so it is better to use type alias instead of comments.
Summary by CodeRabbit