Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename vital#{plugin-name}#of() to vital#{plugin-name}#new() #436

Merged
merged 4 commits into from Aug 9, 2016

Conversation

tyru
Copy link
Member

@tyru tyru commented Jun 4, 2016

Close #431
Ref #432, #435

注意:#435 のブランチをベースにしてます。

@tyru
Copy link
Member Author

tyru commented Jun 4, 2016

Vim 7.4.1890 で Data.Closure のテストが失敗してる…

テスト失敗の内容は #435 と同様。本件のリネームによるテスト失敗はないみたいです。
一応 open-browser.vim でもローカルで vitalize して of() -> new() に変更して無事呼び出せるのを確認済み。

@tyru tyru changed the title [WIP] Rename vital#{plugin-name}#of() to vital#{plugin-name}#new() Rename vital#{plugin-name}#of() to vital#{plugin-name}#new() Jun 4, 2016
@thinca
Copy link
Member

thinca commented Jul 2, 2016

ドキュメントも修正をお願いします。

@tyru
Copy link
Member Author

tyru commented Jul 3, 2016

すみません、了解です。

@thinca
Copy link
Member

thinca commented Aug 8, 2016

ping

@tyru
Copy link
Member Author

tyru commented Aug 8, 2016

@thinca うぅ…すみません今確認しました…のですが、ドキュメントすでに直ってないでしょうか?
直ってない所ってどこでしょう?

@thinca
Copy link
Member

thinca commented Aug 8, 2016

あードキュメントは元ブランチで修正済みなんですね…。理解しました。
これってもう #435 と合わせて作業完了済みであってます? だいぶ間あけてしまったけどマージしてしまおうかな、と。

@tyru
Copy link
Member Author

tyru commented Aug 9, 2016

おそらく完了済のはずです。

@thinca thinca merged commit da96455 into revital-doc Aug 9, 2016
@thinca thinca deleted the rename-revital-of branch August 9, 2016 14:17
@tyru
Copy link
Member Author

tyru commented Aug 9, 2016

あざす!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants