Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Bitwise enhance that is new method imported from vital-codec library's Vim.Type.Number module #675

Merged
merged 4 commits into from
Sep 13, 2019

Conversation

tsuyoshicho
Copy link
Contributor

@tsuyoshicho tsuyoshicho commented Jul 3, 2019

Proposal new library

This library operate Number data

  • uint8/16/32/64 cast operator (bit mask)
  • rotate8/16/32/64 r/l rotate operator

Numberについての型的な処理です。

rotate系はbitwiseとどちらか悩ましいですが、固定長の整数型のビット操作、という意味ではどちらもアリか、と思い、こちらに入れてます。

see #667
ID.UUID
Data.List.Byte
Vim.Type.Number
の依存関係から、まずVim.Type.NumberのPRになります。

@ujihisa
Copy link
Member

ujihisa commented Jul 3, 2019

Hmm, as you've struggled, these functions are kind of in between Bitwise and Number. In my opinion, these functions must belong to Bitwise instead. I expect "Vim.Type.Number" to be more Vim's number specific utilities. Such that would not only include truncating upper bits of the internal representation of a number, but also include modulo, factorial, prime numbers, floating point numbers, or other varieties of them.

@tyru
Copy link
Member

tyru commented Jul 3, 2019

👍 to move the functions to Bitwise module.

@tsuyoshicho
Copy link
Contributor Author

OK move to Bitwise

@tsuyoshicho tsuyoshicho changed the title Proposal new library: Vim.Type.Number Import from vital-codec library at author Proposal: Bitwise enhance that is new method imported from vital-codec library's Vim.Type.Number module Jul 4, 2019
@tsuyoshicho
Copy link
Contributor Author

Hmmm.

Vint review :

  • 🆖 vint check skip
  • 🆗 replace built-in

stay tune

Copy link
Member

@ujihisa ujihisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great thanks!

@ujihisa ujihisa merged commit f18d7c7 into vim-jp:master Sep 13, 2019
@tsuyoshicho tsuyoshicho deleted the proposal/vimtypenumber branch September 14, 2019 07:05
@tsuyoshicho tsuyoshicho restored the proposal/vimtypenumber branch November 14, 2019 08:40
@tsuyoshicho tsuyoshicho deleted the proposal/vimtypenumber branch November 18, 2019 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants