Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accommodate new signatures better #152

Closed
hoelzro opened this issue Feb 26, 2014 · 5 comments
Closed

Accommodate new signatures better #152

hoelzro opened this issue Feb 26, 2014 · 5 comments

Comments

@hoelzro
Copy link
Member

hoelzro commented Feb 26, 2014

Thanks to PR #151, we have some preliminary support for the new signatures feature coming in Perl 5.20. However, it would be nice if this support were on by default, and if it coped well with prototypes.

@zdm
Copy link
Contributor

zdm commented Jun 17, 2014

Subs folding stop working properly when set perl_no_subprototype_error = 1. Please, see screenshots:

All subs unfolded:
unfolded

All folded:
all-folded

@hoelzro
Copy link
Member Author

hoelzro commented Jun 18, 2014

@zdm Thanks for the report; the folds should be fixed in master

@mvgrimes
Copy link

mvgrimes commented Jul 2, 2014

I'm still seeing this issue even with the current master (c79550d).

Unfolded:
screen shot 2014-07-02 at 9 36 24 am

Folded:
screen shot 2014-07-02 at 9 36 36 am

My vim-perl related config:

setlocal foldmethod=syntax
let perl_fold=1
let perl_no_subprototype_error = 1

@hoelzro
Copy link
Member Author

hoelzro commented Jul 2, 2014

Thanks for the report; I've opened a new issue for it in #166

@zdm
Copy link
Contributor

zdm commented Apr 3, 2015

This issue can be closed according to latest changes.

@hoelzro hoelzro closed this as completed Apr 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants