Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problems with highlighting/folding when using subroutine signatures #166

Closed
hoelzro opened this issue Jul 2, 2014 · 8 comments
Closed

Problems with highlighting/folding when using subroutine signatures #166

hoelzro opened this issue Jul 2, 2014 · 8 comments
Labels
Bug: Folding Language: Perl 5 Priority: High

Comments

@hoelzro
Copy link
Member

hoelzro commented Jul 2, 2014

See #151 (comment) and #152 (comment)
@hoelzro hoelzro added the Bug label Jul 2, 2014
This was referenced Jul 2, 2014
Merged
Closed
hoelzro added a commit that referenced this issue Jul 3, 2014
@hoelzro
Add source files for GH #166
9ab291d
@hoelzro
Copy link
Member Author

hoelzro commented Jul 3, 2014

@mvgrimes I've fixed the highlighting issue, but the folding one remains unresolved.

@mvgrimes
Copy link

mvgrimes commented Jul 7, 2014

Thanks heozro. I can confirm the highlighting issue is resolved. The args are now in light green that nearly matches the sub's name. Looks great!

vovkasm added a commit to vovkasm/vim-perl that referenced this issue Jul 9, 2014
@vovkasm
Merge commit 'a7b96b02cbc012fb000de385279ed9f10dd99c06'
1abbbc0 
* commit 'a7b96b02cbc012fb000de385279ed9f10dd99c06':
  Update docs on defaults for Perl settings
  Test folds for subroutine signatures
  Fix highlighting of subroutine signatures
  Add a helper script to launch a pristine Vim
  Add source files for GH vim-perl#166
  Allow test source files to declare custom vim options
@hoelzro hoelzro mentioned this issue Jul 13, 2014
Closed
@zdm
Copy link
Contributor

zdm commented Apr 3, 2015

Seems, that this issue can be closed too.

@markjreed
Copy link

Ok, ran make install with no preexisting .vimrc or .vim directory, turned highlighting on, and function signature parameters still show up highlighted in red, even with let perl_no_subprototype_error=1. Using head of master as of today (2015-12-16). What am I doing wrong?

@zdm
Copy link
Contributor

zdm commented Dec 17, 2015

let perl_sub_signatures = 1

@markjreed
Copy link

Ah! Thanks!

@wesQ3
Copy link

wesQ3 commented Mar 8, 2016

Should this issue be closed?

@hoelzro
Copy link
Member Author

hoelzro commented Mar 8, 2016

Seems so!

@hoelzro hoelzro closed this as completed Mar 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug: Folding Language: Perl 5 Priority: High
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@mvgrimes @hoelzro @markjreed @wesQ3 @zdm