Skip to content
This repository has been archived by the owner on Sep 20, 2023. It is now read-only.

Feedback needed: ok to drop the tsc checker in favour of tsuquyomi? #1811

Closed
lcd047 opened this issue Jul 11, 2016 · 10 comments
Closed

Feedback needed: ok to drop the tsc checker in favour of tsuquyomi? #1811

lcd047 opened this issue Jul 11, 2016 · 10 comments

Comments

@lcd047
Copy link
Collaborator

lcd047 commented Jul 11, 2016

Checker tsc has received some attention lately, several people asking for it to support looking up for a tsconfig.json file, and generally expressing their discontent with the way the checker works in syntastic (cf. #1816, #1807, #1786, #1778, #1734, #1628, #899, and maybe others I can't find right now). On the other hand, some of the same people have recommended tsuquyomi as a better, smoother alternative to the tsc checker. Since checkers maintained by people who care about them are generally in a better position to adapt to people's needs, I propose dropping the internal tsc checker in favour of tsuquyomi.

Unless you have major objections to this move, I'll go ahead with the change in about two weeks (counting from the date of this writing).

@lcd047 lcd047 changed the title Feedback needed: ok to drop the tsc checker in favour of tsuquyomi? Feedback needed: ok to drop the tsc checker in favour of tsuquyomi? Jul 11, 2016
@lcd047
Copy link
Collaborator Author

lcd047 commented Jul 11, 2016

@nomaed There has been ample discussion about the problems with tsc and the solutions suggested by yours truly in the threads I mentioned above. There is even a section in the FAQ essentially dedicated to that. If you have important additions to what has been said before then please either add your notes to one of the existing threads, or post a new issue. I'd prefer this thread to focus on whether tsc should be dropped from syntastic or not.

@lithammer
Copy link

Just wanted to mention that Tsuquyomi also requires Shougo/vimproc.vim.

lcd047 added a commit that referenced this issue Jul 26, 2016
Checker "tsc" has been removed, in favour of the external checker
"tsuquyomi" (https://github.com/Quramy/tsuquyomi).

Reference: #1811
@lcd047
Copy link
Collaborator Author

lcd047 commented Jul 26, 2016

Done in commit 6014bdc. Thank you for the feedback.

@unclechu
Copy link

So, any alternatives? With which one I should replace tsc now?

@nomaed
Copy link

nomaed commented Jul 29, 2016

@unclechu I am using tsuquyomi

@lcd047
Copy link
Collaborator Author

lcd047 commented Jul 29, 2016

Please see also the FAQ.

@unclechu
Copy link

@nomaed Any advise how I can configure auto build for 'Shougo/vimproc.vim'? Like this example for NeoBundle:

NeoBundle 'Shougo/vimproc.vim', {
\ 'build' : {
\     'windows' : 'tools\\update-dll-mingw',
\     'cygwin' : 'make -f make_cygwin.mak',
\     'mac' : 'make -f make_mac.mak',
\     'linux' : 'make',
\     'unix' : 'gmake',
\    },
\ }

NeoBundle 'Quramy/tsuquyomi'

@lcd047
Copy link
Collaborator Author

lcd047 commented Jul 29, 2016

@unclechu This has nothing to do with syntastic any longer, can you please take it to the apropriate forum? Perhaps to the tsuquyomi issue tracker? Thank you!

@unclechu
Copy link

@lcd047 Okay, but I'll paste solution here for anyone who will be frustrated by seeing this issue.

@aminer-looker
Copy link

I'm new to TypeScript, and tried using tsuquyomi and have had nothing but problems (see Quramy/tsuquyomi#82). So, I have, reluctantly, tried to revive support for tsc until the problems have been fixed. You can find my adapted copy on GitHub as well.

The changes I made to work for my environment basically amount to always compiling the whole project instead of the individual file (i.e., using the -p tsconfig.json file), and always using --noEmit on the output (since that option has now been around for a while).

Anyone who, like me, lands here from Google is welcome to use my file to try reverting to tsc.

Slm0n87 pushed a commit to Slm0n87/syntastic that referenced this issue Mar 7, 2019
Checker "tsc" has been removed, in favour of the external checker
"tsuquyomi" (https://github.com/Quramy/tsuquyomi).

Reference: vim-syntastic#1811
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants