Skip to content

Commit

Permalink
patch 9.1.0145: v:echospace not correct when 'showcmdloc' != last
Browse files Browse the repository at this point in the history
Problem:  the amount of available space (v:echospace) on the command
          line is not correct when showcmdloc is drawn into the
          statusline or tabline.
Solution: only add SHOWCMD_COLS to the shown command column when
          'showcmdloc' is set to last (Sam-programs)

closes: #14108

Co-authored-by: zeertzjq <zeertzjq@outlook.com>
Signed-off-by: Sam-programs <130783534+Sam-programs@users.noreply.github.com>
Signed-off-by: Christian Brabandt <cb@256bit.org>
  • Loading branch information
2 people authored and chrisbra committed Feb 29, 2024
1 parent 4d55c54 commit 062141b
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 2 deletions.
1 change: 1 addition & 0 deletions src/optionstr.c
Expand Up @@ -3440,6 +3440,7 @@ did_set_showbreak(optset_T *args)
char *
did_set_showcmdloc(optset_T *args UNUSED)
{
comp_col();
return did_set_opt_strings(p_sloc, p_sloc_values, FALSE);
}

Expand Down
2 changes: 1 addition & 1 deletion src/screen.c
Expand Up @@ -4536,7 +4536,7 @@ comp_col(void)
if (!last_has_status)
sc_col = ru_col;
}
if (p_sc)
if (p_sc && *p_sloc == 'l')
{
sc_col += SHOWCMD_COLS;
if (!p_ru || last_has_status) // no need for separating space
Expand Down
6 changes: 5 additions & 1 deletion src/testdir/test_messages.vim
Expand Up @@ -162,8 +162,12 @@ func Test_echospace()
call assert_equal(&columns - 12, v:echospace)
set showcmd ruler
call assert_equal(&columns - 29, v:echospace)
set showcmdloc=statusline
call assert_equal(&columns - 19, v:echospace)
set showcmdloc=tabline
call assert_equal(&columns - 19, v:echospace)

set ruler& showcmd&
set ruler& showcmd& showcmdloc&
endfunc

func Test_warning_scroll()
Expand Down
2 changes: 2 additions & 0 deletions src/version.c
Expand Up @@ -704,6 +704,8 @@ static char *(features[]) =

static int included_patches[] =
{ /* Add new patch number below this line */
/**/
145,
/**/
144,
/**/
Expand Down

0 comments on commit 062141b

Please sign in to comment.