fix(echospace): don't subtract SHOWCMD_COLS if showcmdloc is statusline or tabline
#14108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeertzjq
reviewed
Feb 28, 2024
Co-authored-by: zeertzjq <zeertzjq@outlook.com>
|
Hmm, it seems that a |
|
Sorry for the delay, i had internet problems. |
|
thank you! |
zeertzjq
added a commit
to zeertzjq/neovim
that referenced
this pull request
Feb 29, 2024
Problem: the amount of available space (v:echospace) on the command
line is not correct when showcmdloc is drawn into the
statusline or tabline.
Solution: only add SHOWCMD_COLS to the shown command column when
'showcmdloc' is set to last (Sam-programs)
closes: vim/vim#14108
vim/vim@062141b
Co-authored-by: Sam-programs <130783534+Sam-programs@users.noreply.github.com>
zeertzjq
added a commit
to neovim/neovim
that referenced
this pull request
Feb 29, 2024
…#27682) Problem: the amount of available space (v:echospace) on the command line is not correct when showcmdloc is drawn into the statusline or tabline. Solution: only add SHOWCMD_COLS to the shown command column when 'showcmdloc' is set to last (Sam-programs) closes: vim/vim#14108 vim/vim@062141b Co-authored-by: Sam-programs <130783534+Sam-programs@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The command is not visible in the message area when
showcmdlocis statusline making echospace smaller than what it can be.