Skip to content

Commit

Permalink
patch 8.2.4568: getmousepos() does not compute the column below the l…
Browse files Browse the repository at this point in the history
…ast line

Problem:    getmousepos() does not compute the column below the last line.
Solution:   Also compute the column when the mouse is below the last line.
            (Sean Dewar, closes #9946)
  • Loading branch information
seandewar authored and brammool committed Mar 15, 2022
1 parent 7a73252 commit 10792fe
Show file tree
Hide file tree
Showing 3 changed files with 27 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/mouse.c
Expand Up @@ -3099,8 +3099,8 @@ f_getmousepos(typval_T *argvars UNUSED, typval_T *rettv)
col -= left_off;
if (row >= 0 && row < wp->w_height && col >= 0 && col < wp->w_width)
{
if (!mouse_comp_pos(wp, &row, &col, &lnum, NULL))
col = vcol2col(wp, lnum, col);
(void)mouse_comp_pos(wp, &row, &col, &lnum, NULL);
col = vcol2col(wp, lnum, col);
column = col + 1;
}
}
Expand Down
23 changes: 23 additions & 0 deletions src/testdir/test_functions.vim
Expand Up @@ -2783,6 +2783,29 @@ func Test_getmousepos()
\ line: 1,
\ column: 8,
\ }, getmousepos())

" If the mouse is positioned past the last buffer line, "line" and "column"
" should act like it's positioned on the last buffer line.
call test_setmouse(2, 25)
call assert_equal(#{
\ screenrow: 2,
\ screencol: 25,
\ winid: win_getid(),
\ winrow: 2,
\ wincol: 25,
\ line: 1,
\ column: 4,
\ }, getmousepos())
call test_setmouse(2, 50)
call assert_equal(#{
\ screenrow: 2,
\ screencol: 50,
\ winid: win_getid(),
\ winrow: 2,
\ wincol: 50,
\ line: 1,
\ column: 8,
\ }, getmousepos())
bwipe!
endfunc

Expand Down
2 changes: 2 additions & 0 deletions src/version.c
Expand Up @@ -750,6 +750,8 @@ static char *(features[]) =

static int included_patches[] =
{ /* Add new patch number below this line */
/**/
4568,
/**/
4567,
/**/
Expand Down

0 comments on commit 10792fe

Please sign in to comment.