Skip to content

Commit

Permalink
patch 8.2.3391: crash with combination of 'linebreak' and other options
Browse files Browse the repository at this point in the history
Problem:    Crash with combination of 'linebreak' and other options.
Solution:   Avoid n_extra to become negative. (Christian Brabandt,
            closes #8817)
  • Loading branch information
brammool committed Aug 31, 2021
1 parent ba02e47 commit 20e0c3d
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 3 deletions.
11 changes: 8 additions & 3 deletions src/drawline.c
Expand Up @@ -1970,17 +1970,22 @@ win_line(
if (wp->w_p_lbr && c0 == c
&& VIM_ISBREAK(c) && !VIM_ISBREAK((int)*ptr))
{
int mb_off = has_mbyte ? (*mb_head_off)(line, ptr - 1) : 0;
char_u *p = ptr - (mb_off + 1);
int mb_off = has_mbyte ? (*mb_head_off)(line, ptr - 1)
: 0;
char_u *p = ptr - (mb_off + 1);

// TODO: is passing p for start of the line OK?
n_extra = win_lbr_chartabsize(wp, line, p, (colnr_T)vcol,
NULL) - 1;

// We have just drawn the showbreak value, no need to add
// space for it again
// space for it again.
if (vcol == vcol_sbr)
{
n_extra -= MB_CHARLEN(get_showbreak_value(wp));
if (n_extra < 0)
n_extra = 0;
}

if (c == TAB && n_extra + col > wp->w_width)
# ifdef FEAT_VARTABS
Expand Down
2 changes: 2 additions & 0 deletions src/version.c
Expand Up @@ -755,6 +755,8 @@ static char *(features[]) =

static int included_patches[] =
{ /* Add new patch number below this line */
/**/
3391,
/**/
3390,
/**/
Expand Down

0 comments on commit 20e0c3d

Please sign in to comment.