Skip to content

Commit

Permalink
patch 8.2.3644: count for 'operatorfunc' in Visual mode is not redone
Browse files Browse the repository at this point in the history
Problem:    Count for 'operatorfunc' in Visual mode is not redone.
Solution:   Add the count to the redo buffer. (closes #9174)
  • Loading branch information
brammool committed Nov 22, 2021
1 parent a3f83fe commit 2228cd7
Show file tree
Hide file tree
Showing 5 changed files with 58 additions and 9 deletions.
26 changes: 23 additions & 3 deletions src/normal.c
Expand Up @@ -380,8 +380,10 @@ static const struct nv_cmd
// Number of commands in nv_cmds[].
#define NV_CMDS_SIZE ARRAY_LENGTH(nv_cmds)

#ifndef PROTO // cproto doesn't like this
// Sorted index of commands in nv_cmds[].
static short nv_cmd_idx[NV_CMDS_SIZE];
#endif

// The highest index for which
// nv_cmds[idx].cmd_char == nv_cmd_idx[nv_cmds[idx].cmd_char]
Expand Down Expand Up @@ -1696,20 +1698,38 @@ prep_redo(
int cmd3,
int cmd4,
int cmd5)
{
prep_redo_num2(regname, num, cmd1, cmd2, 0L, cmd3, cmd4, cmd5);
}

/*
* Prepare for redo of any command with extra count after "cmd2".
*/
void
prep_redo_num2(
int regname,
long num1,
int cmd1,
int cmd2,
long num2,
int cmd3,
int cmd4,
int cmd5)
{
ResetRedobuff();
if (regname != 0) // yank from specified buffer
{
AppendCharToRedobuff('"');
AppendCharToRedobuff(regname);
}
if (num)
AppendNumberToRedobuff(num);

if (num1 != 0)
AppendNumberToRedobuff(num1);
if (cmd1 != NUL)
AppendCharToRedobuff(cmd1);
if (cmd2 != NUL)
AppendCharToRedobuff(cmd2);
if (num2 != 0)
AppendNumberToRedobuff(num2);
if (cmd3 != NUL)
AppendCharToRedobuff(cmd3);
if (cmd4 != NUL)
Expand Down
14 changes: 10 additions & 4 deletions src/ops.c
Expand Up @@ -3764,17 +3764,23 @@ do_pending_operator(cmdarg_T *cap, int old_col, int gui_yank)
oap->motion_force, cap->cmdchar, cap->nchar);
else if (cap->cmdchar != ':' && cap->cmdchar != K_COMMAND)
{
int opchar = get_op_char(oap->op_type);
int extra_opchar = get_extra_op_char(oap->op_type);
int nchar = oap->op_type == OP_REPLACE ? cap->nchar : NUL;

// reverse what nv_replace() did
if (nchar == REPLACE_CR_NCHAR)
nchar = CAR;
else if (nchar == REPLACE_NL_NCHAR)
nchar = NL;
prep_redo(oap->regname, 0L, NUL, 'v',
get_op_char(oap->op_type),
get_extra_op_char(oap->op_type),
nchar);

if (opchar == 'g' && extra_opchar == '@')
// also repeat the count for 'operatorfunc'
prep_redo_num2(oap->regname, 0L, NUL, 'v',
cap->count0, opchar, extra_opchar, nchar);
else
prep_redo(oap->regname, 0L, NUL, 'v',
opchar, extra_opchar, nchar);
}
if (!redo_VIsual_busy)
{
Expand Down
1 change: 1 addition & 0 deletions src/proto/normal.pro
Expand Up @@ -10,6 +10,7 @@ void restore_visual_mode(void);
int find_ident_under_cursor(char_u **text, int find_type);
int find_ident_at_pos(win_T *wp, linenr_T lnum, colnr_T startcol, char_u **text, int *textcol, int find_type);
void prep_redo(int regname, long num, int cmd1, int cmd2, int cmd3, int cmd4, int cmd5);
void prep_redo_num2(int regname, long num1, int cmd1, int cmd2, long num2, int cmd3, int cmd4, int cmd5);
void clearop(oparg_T *oap);
void clearopbeep(oparg_T *oap);
void may_clear_cmdline(void);
Expand Down
24 changes: 22 additions & 2 deletions src/testdir/test_normal.vim
Expand Up @@ -363,7 +363,7 @@ func Test_normal08_fold()
bw!
endfunc

func Test_normal09_operatorfunc()
func Test_normal09a_operatorfunc()
" Test operatorfunc
call Setup_NewWindow()
" Add some spaces for counting
Expand Down Expand Up @@ -457,7 +457,7 @@ func Test_normal09_operatorfunc()
bw!
endfunc

func Test_normal09a_operatorfunc()
func Test_normal09b_operatorfunc()
" Test operatorfunc
call Setup_NewWindow()
" Add some spaces for counting
Expand All @@ -484,6 +484,26 @@ func Test_normal09a_operatorfunc()
unlet! g:opt
endfunc

func OperatorfuncRedo(_)
let g:opfunc_count = v:count
endfunc

func Test_normal09c_operatorfunc()
" Test redoing operatorfunc
new
call setline(1, 'some text')
set operatorfunc=OperatorfuncRedo
normal v3g@
call assert_equal(3, g:opfunc_count)
let g:opfunc_count = 0
normal .
call assert_equal(3, g:opfunc_count)

bw!
unlet g:opfunc_count
set operatorfunc=
endfunc

func Test_normal10_expand()
" Test for expand()
10new
Expand Down
2 changes: 2 additions & 0 deletions src/version.c
Expand Up @@ -757,6 +757,8 @@ static char *(features[]) =

static int included_patches[] =
{ /* Add new patch number below this line */
/**/
3644,
/**/
3643,
/**/
Expand Down

0 comments on commit 2228cd7

Please sign in to comment.