Skip to content

Commit

Permalink
patch 8.0.1215: newer gcc warns for implicit fallthrough
Browse files Browse the repository at this point in the history
Problem:    Newer gcc warns for implicit fallthrough.
Solution:   Consistently use a FALLTHROUGH comment. (Christian Brabandt)
  • Loading branch information
brammool committed Oct 24, 2017
1 parent 4f19828 commit 2f40d12
Show file tree
Hide file tree
Showing 14 changed files with 39 additions and 29 deletions.
2 changes: 2 additions & 0 deletions src/buffer.c
Expand Up @@ -4325,6 +4325,7 @@ build_stl_str_hl(

case STL_OFFSET_X:
base = 'X';
/* FALLTHROUGH */
case STL_OFFSET:
#ifdef FEAT_BYTEOFF
l = ml_find_line_or_offset(wp->w_buffer, wp->w_cursor.lnum, NULL);
Expand All @@ -4336,6 +4337,7 @@ build_stl_str_hl(

case STL_BYTEVAL_X:
base = 'X';
/* FALLTHROUGH */
case STL_BYTEVAL:
num = byteval;
if (num == NL)
Expand Down
5 changes: 4 additions & 1 deletion src/edit.c
Expand Up @@ -984,7 +984,7 @@ edit(
case ESC: /* End input mode */
if (echeck_abbr(ESC + ABBR_OFF))
break;
/*FALLTHROUGH*/
/* FALLTHROUGH */

case Ctrl_C: /* End input mode */
#ifdef FEAT_CMDWIN
Expand Down Expand Up @@ -5774,13 +5774,16 @@ quote_meta(char_u *dest, char_u *src, int len)
if (ctrl_x_mode == CTRL_X_DICTIONARY
|| ctrl_x_mode == CTRL_X_THESAURUS)
break;
/* FALLTHROUGH */
case '~':
if (!p_magic) /* quote these only if magic is set */
break;
/* FALLTHROUGH */
case '\\':
if (ctrl_x_mode == CTRL_X_DICTIONARY
|| ctrl_x_mode == CTRL_X_THESAURUS)
break;
/* FALLTHROUGH */
case '^': /* currently it's not needed. */
case '$':
m++;
Expand Down
4 changes: 2 additions & 2 deletions src/eval.c
Expand Up @@ -6995,7 +6995,7 @@ free_tv(typval_T *varp)
{
case VAR_FUNC:
func_unref(varp->vval.v_string);
/*FALLTHROUGH*/
/* FALLTHROUGH */
case VAR_STRING:
vim_free(varp->vval.v_string);
break;
Expand Down Expand Up @@ -7040,7 +7040,7 @@ clear_tv(typval_T *varp)
{
case VAR_FUNC:
func_unref(varp->vval.v_string);
/*FALLTHROUGH*/
/* FALLTHROUGH */
case VAR_STRING:
vim_free(varp->vval.v_string);
varp->vval.v_string = NULL;
Expand Down
2 changes: 1 addition & 1 deletion src/ex_docmd.c
Expand Up @@ -4115,7 +4115,7 @@ set_one_cmd_context(
case CMD_bunload:
while ((xp->xp_pattern = vim_strchr(arg, ' ')) != NULL)
arg = xp->xp_pattern + 1;
/*FALLTHROUGH*/
/* FALLTHROUGH */
case CMD_buffer:
case CMD_sbuffer:
case CMD_checktime:
Expand Down
3 changes: 1 addition & 2 deletions src/ex_getln.c
Expand Up @@ -1563,9 +1563,8 @@ getcmdline(
break;
goto cmdline_not_changed;
}
/* FALLTHROUGH */

#ifdef FEAT_CMDHIST
/* FALLTHROUGH */
case K_UP:
case K_DOWN:
case K_S_UP:
Expand Down
1 change: 1 addition & 0 deletions src/if_perl.xs
Expand Up @@ -1101,6 +1101,7 @@ perl_to_vim(SV *sv, typval_T *rettv)
rettv->vval.v_number = SvIV(sv);
break;
}
/* FALLTHROUGH */
case SVt_PV: /* string */
{
size_t len = 0;
Expand Down
4 changes: 2 additions & 2 deletions src/main.c
Expand Up @@ -2228,7 +2228,7 @@ command_line_scan(mparm_T *parmp)
argv_idx = -1;
break;
}
/*FALLTHROUGH*/
/* FALLTHROUGH */
case 'S': /* "-S {file}" execute Vim script */
case 'i': /* "-i {viminfo}" use for viminfo */
#ifndef FEAT_DIFF
Expand Down Expand Up @@ -2386,7 +2386,7 @@ command_line_scan(mparm_T *parmp)
argv_idx = -1;
break;
}
/*FALLTHROUGH*/
/* FALLTHROUGH */
case 'W': /* "-W {scriptout}" overwrite script file */
if (scriptout != NULL)
goto scripterror;
Expand Down
5 changes: 3 additions & 2 deletions src/message.c
Expand Up @@ -670,7 +670,8 @@ emsg(char_u *s)

ex_exitval = 1;

/* Reset msg_silent, an error causes messages to be switched back on. */
/* Reset msg_silent, an error causes messages to be switched back on.
*/
msg_silent = 0;
cmd_silent = FALSE;

Expand Down Expand Up @@ -2837,7 +2838,7 @@ do_more_prompt(int typed_char)
skip_redraw = TRUE; /* skip redraw once */
need_wait_return = FALSE; /* don't wait in main() */
}
/*FALLTHROUGH*/
/* FALLTHROUGH */
case 'q': /* quit */
case Ctrl_C:
case ESC:
Expand Down
9 changes: 5 additions & 4 deletions src/normal.c
Expand Up @@ -1945,6 +1945,7 @@ do_pending_operator(cmdarg_T *cap, int old_col, int gui_yank)
AppendToRedobuff((char_u *)"!\r"); /* use any last used !cmd */
else
bangredo = TRUE; /* do_bang() will put cmd in redo buffer */
/* FALLTHROUGH */

case OP_INDENT:
case OP_COLON:
Expand Down Expand Up @@ -5150,7 +5151,7 @@ nv_zet(cmdarg_T *cap)
break;
}
undo = TRUE;
/*FALLTHROUGH*/
/* FALLTHROUGH */

case 'g': /* "zg": add good word to word list */
case 'w': /* "zw": add wrong word to word list */
Expand Down Expand Up @@ -8267,7 +8268,7 @@ nv_g_cmd(cmdarg_T *cap)
/* "g'm" and "g`m": jump to mark without setting pcmark */
case '\'':
cap->arg = TRUE;
/*FALLTHROUGH*/
/* FALLTHROUGH */
case '`':
nv_gomark(cap);
break;
Expand Down Expand Up @@ -8328,7 +8329,7 @@ nv_g_cmd(cmdarg_T *cap)
case 'q':
case 'w':
oap->cursor_start = curwin->w_cursor;
/*FALLTHROUGH*/
/* FALLTHROUGH */
case '~':
case 'u':
case 'U':
Expand Down Expand Up @@ -9117,7 +9118,7 @@ nv_edit(cmdarg_T *cap)
* the first column, then it inserts. */
if (curwin->w_cursor.col == 0)
break;
/*FALLTHROUGH*/
/* FALLTHROUGH */

case 'a': /* "a"ppend is like "i"nsert on the next character. */
#ifdef FEAT_VIRTUALEDIT
Expand Down
12 changes: 6 additions & 6 deletions src/regexp.c
Expand Up @@ -1997,7 +1997,7 @@ regatom(int *flagp)
goto collection;

/* "\_x" is character class plus newline */
/*FALLTHROUGH*/
/* FALLTHROUGH */

/*
* Character classes.
Expand Down Expand Up @@ -5847,7 +5847,7 @@ regrepeat(
case IDENT:
case IDENT + ADD_NL:
testval = TRUE;
/*FALLTHROUGH*/
/* FALLTHROUGH */
case SIDENT:
case SIDENT + ADD_NL:
while (count < maxcount)
Expand Down Expand Up @@ -5877,7 +5877,7 @@ regrepeat(
case KWORD:
case KWORD + ADD_NL:
testval = TRUE;
/*FALLTHROUGH*/
/* FALLTHROUGH */
case SKWORD:
case SKWORD + ADD_NL:
while (count < maxcount)
Expand Down Expand Up @@ -5908,7 +5908,7 @@ regrepeat(
case FNAME:
case FNAME + ADD_NL:
testval = TRUE;
/*FALLTHROUGH*/
/* FALLTHROUGH */
case SFNAME:
case SFNAME + ADD_NL:
while (count < maxcount)
Expand Down Expand Up @@ -5938,7 +5938,7 @@ regrepeat(
case PRINT:
case PRINT + ADD_NL:
testval = TRUE;
/*FALLTHROUGH*/
/* FALLTHROUGH */
case SPRINT:
case SPRINT + ADD_NL:
while (count < maxcount)
Expand Down Expand Up @@ -6131,7 +6131,7 @@ regrepeat(
case ANYOF:
case ANYOF + ADD_NL:
testval = TRUE;
/*FALLTHROUGH*/
/* FALLTHROUGH */

case ANYBUT:
case ANYBUT + ADD_NL:
Expand Down
3 changes: 2 additions & 1 deletion src/regexp_nfa.c
Expand Up @@ -1320,7 +1320,7 @@ nfa_regatom(void)
goto collection;

/* "\_x" is character class plus newline */
/*FALLTHROUGH*/
/* FALLTHROUGH */

/*
* Character classes.
Expand Down Expand Up @@ -4698,6 +4698,7 @@ addstate(
subs = addstate(l, state->out, subs, pim, off_arg);
break;
}
/* FALLTHROUGH */
case NFA_MCLOSE1:
case NFA_MCLOSE2:
case NFA_MCLOSE3:
Expand Down
12 changes: 6 additions & 6 deletions src/spell.c
Expand Up @@ -5019,7 +5019,7 @@ suggest_trie_walk(
}
PROF_STORE(sp->ts_state)
sp->ts_state = STATE_PLAIN;
/*FALLTHROUGH*/
/* FALLTHROUGH */

case STATE_PLAIN:
/*
Expand Down Expand Up @@ -5243,7 +5243,7 @@ suggest_trie_walk(
}
break;
}
/*FALLTHROUGH*/
/* FALLTHROUGH */

case STATE_INS_PREP:
if (sp->ts_flags & TSF_DIDDEL)
Expand Down Expand Up @@ -5277,7 +5277,7 @@ suggest_trie_walk(
}
break;

/*FALLTHROUGH*/
/* FALLTHROUGH */

case STATE_INS:
/* Insert one byte. Repeat this for each possible byte at this
Expand Down Expand Up @@ -5464,7 +5464,7 @@ suggest_trie_walk(
*p = p[1];
p[1] = c;
}
/*FALLTHROUGH*/
/* FALLTHROUGH */

case STATE_SWAP3:
/* Swap two bytes, skipping one: "123" -> "321". We change
Expand Down Expand Up @@ -5703,7 +5703,7 @@ suggest_trie_walk(
p[1] = p[2];
p[2] = c;
}
/*FALLTHROUGH*/
/* FALLTHROUGH */

case STATE_REP_INI:
/* Check if matching with REP items from the .aff file would work.
Expand Down Expand Up @@ -5736,7 +5736,7 @@ suggest_trie_walk(

PROF_STORE(sp->ts_state)
sp->ts_state = STATE_REP;
/*FALLTHROUGH*/
/* FALLTHROUGH */

case STATE_REP:
/* Try matching with REP items from the .aff file. For each match
Expand Down
2 changes: 2 additions & 0 deletions src/version.c
Expand Up @@ -761,6 +761,8 @@ static char *(features[]) =

static int included_patches[] =
{ /* Add new patch number below this line */
/**/
1215,
/**/
1214,
/**/
Expand Down
4 changes: 2 additions & 2 deletions src/window.c
Expand Up @@ -433,8 +433,8 @@ do_window(
g_do_tagpreview = Prenum;
else
g_do_tagpreview = p_pvh;
/*FALLTHROUGH*/
#endif
/* FALLTHROUGH */
case ']':
case Ctrl_RSB:
CHECK_CMDWIN
Expand Down Expand Up @@ -557,8 +557,8 @@ do_window(
g_do_tagpreview = Prenum;
else
g_do_tagpreview = p_pvh;
/*FALLTHROUGH*/
#endif
/* FALLTHROUGH */
case ']':
case Ctrl_RSB:
/* keep Visual mode, can select words to use as a tag */
Expand Down

0 comments on commit 2f40d12

Please sign in to comment.