Skip to content

Commit

Permalink
patch 9.0.1049: crash when opening a very small terminal window
Browse files Browse the repository at this point in the history
Problem:    Crash when opening a very small terminal window.
Solution:   Instead of crashing fix the cursor position. (closes #11697)
  • Loading branch information
brammool committed Dec 12, 2022
1 parent b7acea1 commit 67578e5
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 2 deletions.
10 changes: 8 additions & 2 deletions src/libvterm/src/screen.c
Expand Up @@ -661,9 +661,15 @@ static void resize_buffer(VTermScreen *screen, int bufidx, int new_rows, int new
}

/* We really expect the cursor position to be set by now */
/* Unfortunately we do get here when "new_rows" is one. We don't want
* to crash, so until the above code is fixed let's just set the cursor. */
if(active && (new_cursor.row == -1 || new_cursor.col == -1)) {
fprintf(stderr, "screen_resize failed to update cursor position\n");
abort();
/* fprintf(stderr, "screen_resize failed to update cursor position\n");
* abort(); */
if (new_cursor.row < 0)
new_cursor.row = 0;
if (new_cursor.col < 0)
new_cursor.col = 0;
}

if(old_row >= 0 && bufidx == BUFIDX_PRIMARY) {
Expand Down
2 changes: 2 additions & 0 deletions src/version.c
Expand Up @@ -695,6 +695,8 @@ static char *(features[]) =

static int included_patches[] =
{ /* Add new patch number below this line */
/**/
1049,
/**/
1048,
/**/
Expand Down

0 comments on commit 67578e5

Please sign in to comment.