Skip to content

Commit

Permalink
patch 8.0.0998: strange error when using K while only spaces are sele…
Browse files Browse the repository at this point in the history
…cted

Problem:    Strange error when using K while only spaces are selected.
            (Christian J. Robinson)
Solution:   Check for blank argument.
  • Loading branch information
brammool committed Aug 26, 2017
1 parent e922460 commit a4f99f5
Show file tree
Hide file tree
Showing 3 changed files with 24 additions and 0 deletions.
5 changes: 5 additions & 0 deletions src/normal.c
Expand Up @@ -5648,6 +5648,11 @@ nv_ident(cmdarg_T *cap)
kp = (*curbuf->b_p_kp == NUL ? p_kp : curbuf->b_p_kp);
kp_help = (*kp == NUL || STRCMP(kp, ":he") == 0
|| STRCMP(kp, ":help") == 0);
if (kp_help && *skipwhite(ptr) == NUL)
{
EMSG(_(e_noident)); /* found white space only */
return;
}
kp_ex = (*kp == ':');
buflen = (unsigned)(n * 2 + 30 + STRLEN(kp));
buf = alloc(buflen);
Expand Down
17 changes: 17 additions & 0 deletions src/testdir/test_help.vim
Expand Up @@ -12,4 +12,21 @@ endfunc
func Test_help_errors()
call assert_fails('help doesnotexist', 'E149:')
call assert_fails('help!', 'E478:')

new
set keywordprg=:help
call setline(1, " ")
call assert_fails('normal VK', 'E349:')
bwipe!
endfunc

func Test_help_keyword()
new
set keywordprg=:help
call setline(1, " Visual ")
normal VK
call assert_match('^Visual mode', getline('.'))
call assert_equal('help', &ft)
close
bwipe!
endfunc
2 changes: 2 additions & 0 deletions src/version.c
Expand Up @@ -769,6 +769,8 @@ static char *(features[]) =

static int included_patches[] =
{ /* Add new patch number below this line */
/**/
998,
/**/
997,
/**/
Expand Down

0 comments on commit a4f99f5

Please sign in to comment.