Permalink
Browse files

patch 8.0.0998: strange error when using K while only spaces are sele…

…cted

Problem:    Strange error when using K while only spaces are selected.
            (Christian J. Robinson)
Solution:   Check for blank argument.
  • Loading branch information...
brammool committed Aug 26, 2017
1 parent e922460 commit a4f99f5a8b827162a26ca4e4d59f4f224503398a
Showing with 24 additions and 0 deletions.
  1. +5 −0 src/normal.c
  2. +17 −0 src/testdir/test_help.vim
  3. +2 −0 src/version.c
View
@@ -5648,6 +5648,11 @@ nv_ident(cmdarg_T *cap)
kp = (*curbuf->b_p_kp == NUL ? p_kp : curbuf->b_p_kp);
kp_help = (*kp == NUL || STRCMP(kp, ":he") == 0
|| STRCMP(kp, ":help") == 0);
if (kp_help && *skipwhite(ptr) == NUL)
{
EMSG(_(e_noident)); /* found white space only */
return;
}
kp_ex = (*kp == ':');
buflen = (unsigned)(n * 2 + 30 + STRLEN(kp));
buf = alloc(buflen);
View
@@ -12,4 +12,21 @@ endfunc
func Test_help_errors()
call assert_fails('help doesnotexist', 'E149:')
call assert_fails('help!', 'E478:')
new
set keywordprg=:help
call setline(1, " ")
call assert_fails('normal VK', 'E349:')
bwipe!
endfunc
func Test_help_keyword()
new
set keywordprg=:help
call setline(1, " Visual ")
normal VK
call assert_match('^Visual mode', getline('.'))
call assert_equal('help', &ft)
close
bwipe!
endfunc
View
@@ -769,6 +769,8 @@ static char *(features[]) =
static int included_patches[] =
{ /* Add new patch number below this line */
/**/
998,
/**/
997,
/**/

0 comments on commit a4f99f5

Please sign in to comment.