patch 8.2.4051: compiler complains about possibly uninitialized variable

Problem: Compiler complains about possibly uninitialized variable. Solution: Add code to avoid a compiler warning. (John Marriott)
vim · Jan 10, 2022 · b06cfcf · b06cfcf
1 parent dc4451d
commit b06cfcf
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/src/scriptfile.c b/src/scriptfile.c
@@ -274,7 +274,7 @@ get_new_scriptitem(int *error)
 {
     static scid_T   last_current_SID = 0;
     int		    sid = ++last_current_SID;
-    scriptitem_T    *si;
+    scriptitem_T    *si = NULL;
 
     if (ga_grow(&script_items, (int)(sid - script_items.ga_len)) == FAIL)
     {
@@ -305,8 +305,10 @@ get_new_scriptitem(int *error)
 # endif
     }
 
-    // Used to check script variable index is still valid.
-    si->sn_script_seq = current_sctx.sc_seq;
+    // "si" can't be NULL, check only to avoid a compiler warning
+    if (si != NULL)
+	// Used to check script variable index is still valid.
+	si->sn_script_seq = current_sctx.sc_seq;
 
     return sid;
 }

diff --git a/src/version.c b/src/version.c
@@ -750,6 +750,8 @@ static char *(features[]) =
 
 static int included_patches[] =
 {   /* Add new patch number below this line */
+/**/
+    4051,
 /**/
     4050,
 /**/