Skip to content

Commit

Permalink
patch 8.2.3930: getcmdline() argument has a misleading type
Browse files Browse the repository at this point in the history
Problem:    getcmdline() argument has a misleading type.
Solution:   Use the correct type, even though the value is not used.
  • Loading branch information
brammool committed Dec 28, 2021
1 parent 10c75c4 commit c97f9a5
Show file tree
Hide file tree
Showing 7 changed files with 11 additions and 9 deletions.
2 changes: 1 addition & 1 deletion src/ex_docmd.c
Expand Up @@ -1467,7 +1467,7 @@ get_loop_line(int c, void *cookie, int indent, getline_opt_T options)

// First time inside the ":while"/":for": get line normally.
if (cp->getline == NULL)
line = getcmdline(c, 0L, indent, options);
line = getcmdline(c, 0L, indent, 0);
else
line = cp->getline(c, cp->cookie, indent, options);
if (line != NULL && store_loop_line(cp->lines_gap, line) == OK)
Expand Down
8 changes: 4 additions & 4 deletions src/ex_getln.c
Expand Up @@ -1554,10 +1554,10 @@ init_ccline(int firstc, int indent)
*/
char_u *
getcmdline(
int firstc,
long count, // only used for incremental search
int indent, // indent for inside conditionals
int do_concat UNUSED)
int firstc,
long count, // only used for incremental search
int indent, // indent for inside conditionals
getline_opt_T do_concat UNUSED)
{
return getcmdline_int(firstc, count, indent, TRUE);
}
Expand Down
2 changes: 1 addition & 1 deletion src/normal.c
Expand Up @@ -4388,7 +4388,7 @@ nv_search(cmdarg_T *cap)

// When using 'incsearch' the cursor may be moved to set a different search
// start position.
cap->searchbuf = getcmdline(cap->cmdchar, cap->count1, 0, TRUE);
cap->searchbuf = getcmdline(cap->cmdchar, cap->count1, 0, 0);

if (cap->searchbuf == NULL)
{
Expand Down
2 changes: 1 addition & 1 deletion src/proto/ex_getln.pro
@@ -1,6 +1,6 @@
/* ex_getln.c */
void cmdline_init(void);
char_u *getcmdline(int firstc, long count, int indent, int do_concat);
char_u *getcmdline(int firstc, long count, int indent, getline_opt_T do_concat);
char_u *getcmdline_prompt(int firstc, char_u *prompt, int attr, int xp_context, char_u *xp_arg);
int check_opt_wim(void);
int text_and_win_locked(void);
Expand Down
2 changes: 1 addition & 1 deletion src/register.c
Expand Up @@ -97,7 +97,7 @@ get_expr_register(void)
{
char_u *new_line;

new_line = getcmdline('=', 0L, 0, TRUE);
new_line = getcmdline('=', 0L, 0, 0);
if (new_line == NULL)
return NUL;
if (*new_line == NUL) // use previous line
Expand Down
2 changes: 1 addition & 1 deletion src/userfunc.c
Expand Up @@ -180,7 +180,7 @@ get_function_line(
char_u *theline;

if (eap->getline == NULL)
theline = getcmdline(':', 0L, indent, getline_options);
theline = getcmdline(':', 0L, indent, 0);
else
theline = eap->getline(':', eap->cookie, indent, getline_options);
if (theline != NULL)
Expand Down
2 changes: 2 additions & 0 deletions src/version.c
Expand Up @@ -749,6 +749,8 @@ static char *(features[]) =

static int included_patches[] =
{ /* Add new patch number below this line */
/**/
3930,
/**/
3929,
/**/
Expand Down

0 comments on commit c97f9a5

Please sign in to comment.