Skip to content

Commit

Permalink
patch 8.2.1594: pull requests on github do not notify a maintainer
Browse files Browse the repository at this point in the history
Problem:    Pull requests on github do not notify a maintainer.
Solution:   Add a CODEOWNERS file with a few initial entries.
  • Loading branch information
brammool committed Sep 5, 2020
1 parent e2e4075 commit cf8aa64
Show file tree
Hide file tree
Showing 3 changed files with 53 additions and 0 deletions.
50 changes: 50 additions & 0 deletions .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
@@ -0,0 +1,50 @@
# Lines starting with '#' are comments.
# Each line is a file pattern followed by one or more owners.
# You can use github users with @user or email addresses

# These owners will be the default owners for everything in the repo.
* @defunkt

This comment has been minimized.

Copy link
@k-takata

k-takata Sep 5, 2020

Member

I think this line should be:

*       @brammool

This comment has been minimized.

Copy link
@brammool

brammool Sep 5, 2020

Author Contributor

I'm already getting all pull requests, does this have any effect? Or give me duplicate messages?

This comment has been minimized.

Copy link
@k-takata

k-takata Sep 5, 2020

Member

You may see this blog? https://github.blog/2017-07-06-introducing-code-owners/
@defunkt is just an example and it should be replaced by the owner of the repository. In this case, you.
Otherwise, all PRs will be notified to https://github.com/defunkt from now.

This comment has been minimized.

Copy link
@brammool

brammool via email Sep 5, 2020

Author Contributor

# Order is important. The last matching pattern has the most precedence.
# So if a pull request only touches javascript files, only these owners
# will be requested to review.

src/libvterm/* @leonerd

runtime/autoload/getscript.vim @cecamp
runtime/autoload/netrw.vim @cecamp
runtime/autoload/netrwFileHandlers.vim @cecamp
runtime/autoload/netrwSettings.vim @cecamp
runtime/autoload/tar.vim @cecamp
runtime/autoload/vimball.vim @cecamp
runtime/autoload/zip.vim @cecamp
runtime/doc/pi_getscript.txt @cecamp
runtime/doc/pi_logipat.txt @cecamp
runtime/doc/pi_netrw.txt @cecamp
runtime/doc/pi_tar.txt @cecamp
runtime/doc/pi_vimball.txt @cecamp
runtime/doc/pi_zip.txt @cecamp
runtime/plugin/getscriptPlugin.vim @cecamp
runtime/plugin/logiPat.vim @cecamp
runtime/plugin/netrwPlugin.vim @cecamp
runtime/plugin/tarPlugin.vim @cecamp
runtime/plugin/vimballPlugin.vim @cecamp
runtime/plugin/zipPlugin.vim @cecamp
runtime/plugin/amiga.vim @cecamp
runtime/plugin/csh.vim @cecamp
runtime/plugin/dcl.vim @cecamp
runtime/plugin/wlmfilt.vim @cecamp
runtime/plugin/exports.vim @cecamp
runtime/plugin/lex.vim @cecamp
runtime/plugin/lisp.vim @cecamp
runtime/plugin/maple.vim @cecamp
runtime/plugin/netrw.vim @cecamp
runtime/plugin/rpcgen.vim @cecamp
runtime/plugin/sh.vim @cecamp
runtime/plugin/sm.vim @cecamp
runtime/plugin/tags.vim @cecamp
runtime/plugin/tex.vim @cecamp
runtime/plugin/vim.vim @cecamp
runtime/plugin/xmath.vim @cecamp
runtime/plugin/xxd.vim @cecamp
runtime/plugin/yacc.vim @cecamp
1 change: 1 addition & 0 deletions Filelist
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ SRC_ALL = \
.travis.yml \
.cirrus.yml \
.github/workflows/ci-windows.yaml \
.github/CODEOWNERS \
appveyor.yml \
ci/appveyor.bat \
ci/if_ver*.vim \
Expand Down
2 changes: 2 additions & 0 deletions src/version.c
Original file line number Diff line number Diff line change
Expand Up @@ -754,6 +754,8 @@ static char *(features[]) =

static int included_patches[] =
{ /* Add new patch number below this line */
/**/
1594,
/**/
1593,
/**/
Expand Down

0 comments on commit cf8aa64

Please sign in to comment.