patch 8.2.4652: leaking memory if assignment fails

Problem: Leaking memory if assignment fails. Solution: Clear assigned value on failure.
vim · Mar 31, 2022 · d1d2684 · d1d2684
1 parent 1712518
commit d1d2684
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/src/version.c b/src/version.c
@@ -750,6 +750,8 @@ static char *(features[]) =
 
 static int included_patches[] =
 {   /* Add new patch number below this line */
+/**/
+    4652,
 /**/
     4651,
 /**/

diff --git a/src/vim9execute.c b/src/vim9execute.c
@@ -3098,6 +3098,7 @@ exec_instructions(ectx_T *ectx)
 			if (iptr->isn_type == ISN_STOREEXPORT)
 			{
 			    semsg(_(e_undefined_variable_str), name);
+			    clear_tv(STACK_TV_BOT(0));
 			    goto on_error;
 			}
 			store_var(name, STACK_TV_BOT(0));
@@ -3118,6 +3119,7 @@ exec_instructions(ectx_T *ectx)
 				{
 				    semsg(_(e_item_not_exported_in_script_str),
 									 name);
+				    clear_tv(STACK_TV_BOT(0));
 				    goto on_error;
 				}
 			    }