Skip to content

Commit

Permalink
patch 7.4.2326
Browse files Browse the repository at this point in the history
Problem:    Illegal memory access when Visual selection starts in invalid
            position. (Dominique Pelle)
Solution:   Correct position when needed.
  • Loading branch information
brammool committed Sep 4, 2016
1 parent 30180b8 commit d5824ce
Show file tree
Hide file tree
Showing 4 changed files with 28 additions and 0 deletions.
22 changes: 22 additions & 0 deletions src/misc2.c
Original file line number Diff line number Diff line change
Expand Up @@ -504,6 +504,28 @@ get_cursor_rel_lnum(
return retval;
}

/*
* Make sure "pos.lnum" and "pos.col" are valid in "buf".
* This allows for the col to be on the NUL byte.
*/
void
check_pos(buf_T *buf, pos_T *pos)
{
char_u *line;
colnr_T len;

if (pos->lnum > buf->b_ml.ml_line_count)
pos->lnum = buf->b_ml.ml_line_count;

if (pos->col > 0)
{
line = ml_get_buf(buf, pos->lnum, FALSE);
len = (colnr_T)STRLEN(line);
if (pos->col > len)
pos->col = len;
}
}

/*
* Make sure curwin->w_cursor.lnum is valid.
*/
Expand Down
3 changes: 3 additions & 0 deletions src/normal.c
Original file line number Diff line number Diff line change
Expand Up @@ -9451,7 +9451,10 @@ get_op_vcol(
#ifdef FEAT_MBYTE
/* prevent from moving onto a trail byte */
if (has_mbyte)
{
check_pos(curwin->w_buffer, &oap->end);
mb_adjustpos(curwin->w_buffer, &oap->end);
}
#endif

getvvcol(curwin, &(oap->start), &oap->start_vcol, NULL, &oap->end_vcol);
Expand Down
1 change: 1 addition & 0 deletions src/proto/misc2.pro
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ int dec_cursor(void);
int dec(pos_T *lp);
int decl(pos_T *lp);
linenr_T get_cursor_rel_lnum(win_T *wp, linenr_T lnum);
void check_pos(buf_T *buf, pos_T *pos);
void check_cursor_lnum(void);
void check_cursor_col(void);
void check_cursor_col_win(win_T *win);
Expand Down
2 changes: 2 additions & 0 deletions src/version.c
Original file line number Diff line number Diff line change
Expand Up @@ -763,6 +763,8 @@ static char *(features[]) =

static int included_patches[] =
{ /* Add new patch number below this line */
/**/
2326,
/**/
2325,
/**/
Expand Down

0 comments on commit d5824ce

Please sign in to comment.