Skip to content

Commit

Permalink
patch 9.0.1327: cursor in wrong position below line with virtual text…
Browse files Browse the repository at this point in the history
… below

Problem:    Cursor in wrong position below line with virtual text below ending
            in multi-byte character.
Solution:   When checking for last character take care of multi-byte
            character.
  • Loading branch information
brammool committed Feb 19, 2023
1 parent a572b93 commit ea62cee
Show file tree
Hide file tree
Showing 4 changed files with 34 additions and 1 deletion.
2 changes: 1 addition & 1 deletion src/charset.c
Expand Up @@ -1196,7 +1196,7 @@ win_lbr_chartabsize(
|| (tp->tp_col == MAXCOL
&& ((tp->tp_flags & TP_FLAG_ALIGN_ABOVE)
? col == 0
: (s[0] == NUL || s[1] == NUL)
: (s[0] == NUL || s[charlen] == NUL)
&& cts->cts_with_trailing)))
&& -tp->tp_id - 1 < gap->ga_len)
{
Expand Down
10 changes: 10 additions & 0 deletions src/testdir/dumps/Test_prop_multibyte_below_1.dump
@@ -0,0 +1,10 @@
| +0#af5f00255#ffffff0@1|1| |©+0#0000000&| @54
| +0#af5f00255&@3|++0#0000001#ffff4012@2| +0#0000000#ffffff0@52
| +0#af5f00255&@1|2| |©+0#0000000&| @54
| +0#af5f00255&@3|++0#0000001#ffff4012@2| +0#0000000#ffffff0@52
| +0#af5f00255&@1|3| >©+0#0000000&| @54
| +0#af5f00255&@3|++0#0000001#ffff4012@2| +0#0000000#ffffff0@52
|~+0#4040ff13&| @58
|~| @58
|~| @58
| +0#0000000&@41|3|,|1| @10|A|l@1|
21 changes: 21 additions & 0 deletions src/testdir/test_textprop.vim
Expand Up @@ -2817,6 +2817,27 @@ func Test_prop_with_text_above_below_empty()
call StopVimInTerminal(buf)
endfunc

func Test_prop_with_multibyte_below()
CheckRunVimInTerminal

let lines =<< trim END
setlocal number
call setline(1, ['©', '©', '©'])

let vt = 'test'
call prop_type_add(vt, {'highlight': 'ToDo'})
for ln in range(1, line('$'))
call prop_add(ln, 0, {'type': vt, 'text': '+++', 'text_align': 'below'})
endfor
normal G
END
call writefile(lines, 'XscriptPropMultibyteBelow', 'D')
let buf = RunVimInTerminal('-S XscriptPropMultibyteBelow', #{rows: 10, cols: 60})
call VerifyScreenDump(buf, 'Test_prop_multibyte_below_1', {})

call StopVimInTerminal(buf)
endfunc

func Test_prop_with_text_above_empty()
CheckRunVimInTerminal

Expand Down
2 changes: 2 additions & 0 deletions src/version.c
Expand Up @@ -695,6 +695,8 @@ static char *(features[]) =

static int included_patches[] =
{ /* Add new patch number below this line */
/**/
1327,
/**/
1326,
/**/
Expand Down

0 comments on commit ea62cee

Please sign in to comment.