Skip to content

Commit

Permalink
patch 8.2.4486: MS-Windows GUI: slow scrolling with maximized window
Browse files Browse the repository at this point in the history
Problem:    MS-Windows GUI: slow scrolling with maximized window.
Solution:   Use a better way to check the window is on screen. (Ken Takata,
            closes #9865)
  • Loading branch information
brammool committed Mar 1, 2022
1 parent 3e7637b commit f01af9c
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 6 deletions.
19 changes: 13 additions & 6 deletions src/gui_w32.c
Original file line number Diff line number Diff line change
Expand Up @@ -3016,7 +3016,7 @@ is_point_onscreen(int x, int y)
}

/*
* Check if the whole area of the specified window is on-screen.
* Check if the whole client area of the specified window is on-screen.
*
* Note about DirectX: Windows 10 1809 or above no longer maintains image of
* the window portion that is off-screen. Scrolling by DWriteContext_Scroll()
Expand All @@ -3026,16 +3026,23 @@ is_point_onscreen(int x, int y)
is_window_onscreen(HWND hwnd)
{
RECT rc;
POINT p1, p2;

GetWindowRect(hwnd, &rc);
GetClientRect(hwnd, &rc);
p1.x = rc.left;
p1.y = rc.top;
p2.x = rc.right - 1;
p2.y = rc.bottom - 1;
ClientToScreen(hwnd, &p1);
ClientToScreen(hwnd, &p2);

if (!is_point_onscreen(rc.left, rc.top))
if (!is_point_onscreen(p1.x, p1.y))
return FALSE;
if (!is_point_onscreen(rc.left, rc.bottom))
if (!is_point_onscreen(p1.x, p2.y))
return FALSE;
if (!is_point_onscreen(rc.right, rc.top))
if (!is_point_onscreen(p2.x, p1.y))
return FALSE;
if (!is_point_onscreen(rc.right, rc.bottom))
if (!is_point_onscreen(p2.x, p2.y))
return FALSE;
return TRUE;
}
Expand Down
2 changes: 2 additions & 0 deletions src/version.c
Original file line number Diff line number Diff line change
Expand Up @@ -754,6 +754,8 @@ static char *(features[]) =

static int included_patches[] =
{ /* Add new patch number below this line */
/**/
4486,
/**/
4485,
/**/
Expand Down

0 comments on commit f01af9c

Please sign in to comment.