Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test_previewpopup fails when path doesn't fit on one line of terminal #5615

Closed
meithecatte opened this issue Feb 10, 2020 · 3 comments
Closed

Test_previewpopup fails when path doesn't fit on one line of terminal #5615

meithecatte opened this issue Feb 10, 2020 · 3 comments

Comments

@meithecatte
Copy link

Describe the bug
When running the tests with the vim source in a directory with a long path, Test_previewpopup fails:

Failures:
        From test_popupwin.vim:
        Found errors in Test_previewpopup():
        Run 1:
        function RunTheTest[40]..Test_previewpopup[54]..VerifyScreenDump line 55: See dump file difference: call term_dumpdiff("testdir/failed/Test_popupwin_previewpopup_5.dump", "testdir/dumps/Test_popupwin_previewpopup_5.dump"); difference in line 6: "|s+0#0000000#ffffff0|i|x| @29|║+0#0000001#ffd7ff255| +0#0000000#ffffff0@38| +0&#a8a8a8255|║+0#0000001#ffd7ff255"; difference in line 7: "|s+0#0000000#ffffff0|e|v|e|n| @27|║+0#0000001#ffd7ff255| +0#0000000#ffffff0@38| +0&#a8a8a8255|║+0#0000001#ffd7ff255"; difference in line 8: "|f+0#0000000#ffffff0|i|n|d| |t|h|e|w|o|r|d| |s|o|m|e|w|h|e|r|e| @10|║+0#0000001#ffd7ff255| +0#0000000#ffffff0@38| +0&#0000001|║+0#0000001#ffd7ff255"; difference in line 9: "|n+0#0000000#ffffff0|i|n|e| @28|║+0#0000001#ffd7ff255| +0#0000000#ffffff0@38| +0&#a8a8a8255|║+0#0000001#ffd7ff255"; difference in line 14: "| +0#0000000&@56|1@1|,|3|9| @8|A|l@1| "
        Run 2:
        function RunTheTest[40]..Test_previewpopup[54]..VerifyScreenDump line 55: See dump file difference: call term_dumpdiff("testdir/failed/Test_popupwin_previewpopup_5.dump", "testdir/dumps/Test_popupwin_previewpopup_5.dump"); difference in line 6: "|s+0#0000000#ffffff0|i|x| @29|║+0#0000001#ffd7ff255| +0#0000000#ffffff0@38| +0&#a8a8a8255|║+0#0000001#ffd7ff255"; difference in line 7: "|s+0#0000000#ffffff0|e|v|e|n| @27|║+0#0000001#ffd7ff255| +0#0000000#ffffff0@38| +0&#a8a8a8255|║+0#0000001#ffd7ff255"; difference in line 8: "|f+0#0000000#ffffff0|i|n|d| |t|h|e|w|o|r|d| |s|o|m|e|w|h|e|r|e| @10|║+0#0000001#ffd7ff255| +0#0000000#ffffff0@38| +0&#0000001|║+0#0000001#ffd7ff255"; difference in line 9: "|n+0#0000000#ffffff0|i|n|e| @28|║+0#0000001#ffd7ff255| +0#0000000#ffffff0@38| +0&#a8a8a8255|║+0#0000001#ffd7ff255"; difference in line 14: "| +0#0000000&@56|1@1|,|3|9| @8|A|l@1| "
        Flaky test failed too often, giving up

TEST FAILURE
make[2]: *** [Makefile:58: report] Error 1
make[2]: Leaving directory '/tmp/guix-build-vim-full-8.2.0236.drv-0/source/src/testdir'
make[1]: *** [Makefile:2218: scripttests] Error 2
make[1]: Leaving directory '/tmp/guix-build-vim-full-8.2.0236.drv-0/source/src'
make: *** [Makefile:39: test] Error 2

I also managed to reproduce the error this test is finding by manually executing the steps the test is taking:

vim-test2

vim-test

Environment (please complete the following information):

  • Vim version: 8.2.0236
  • OS: GNU Guix
  • Terminal: urxvt + tmux

Additional context
I ran into this issue when trying to update the definition of the vim-full package on Guix. I will skip this test for now.
@brammool
Copy link
Contributor

I can reproduce it and I know how to fix it. But I still wonder why the popup isn't redrawn.

@meithecatte
Copy link
Author

I feel like the popup not being redrawn is the root cause, and should be investigated as a separate bug.

@brammool
Copy link
Contributor

I haven't managed to reproduce the redraw problem interactively.

janlazo added a commit to janlazo/neovim that referenced this issue Nov 26, 2020
@janlazo
vim-patch:8.2.0462: previewwindow test fails on some systems
fe5dc26 
Problem:    Previewwindow test fails on some systems. (James McCoy)
Solution:   Wait a bit after sending the "o". (closes vim/vim#5849)
vim/vim@37bb030

Cherry-pick Test_popup_and_previewwindow_dump() changes
from patches 8.1.1585, 8.1.2373.

N/A patches for version.c:

vim-patch:8.2.0242: preview popup window test fails with long directory name

Problem:    Preview popup window test fails with long directory name. (Jakub
            Kądziołka)
Solution:   Use "silent cd". (closes vim/vim#5615)
vim/vim@799439a

vim-patch:8.2.2042: build failure with +profile but without +reltime

Problem:    Build failure with +profile but without +reltime.
Solution:   Adjust #ifdef. (Christian Brabandt, closes vim/vim#7361)
vim/vim@8131967

vim-patch:8.2.2043: GTK3: white border around text stands out

Problem:    GTK3: white border around text stands out.
Solution:   Use current theme color. (closes vim/vim#7357, issue vim/vim#349)
vim/vim@ff94bd9

vim-patch:8.2.2047: Amiga: FEAT_ARP defined when it should not

Problem:    Amiga: FEAT_ARP defined when it should not.
Solution:   Adjust #ifdef. (Ola Söder, closes vim/vim#7370)
vim/vim@36fe7b2

vim-patch:8.2.2048: Amiga: obsolete code

Problem:    Amiga: obsolete code.
Solution:   Remove the unused lines. (Ola Söder, closes vim/vim#7373)
vim/vim@3a3b691

vim-patch:8.2.2049: Amiga: obsolete function

Problem:    Amiga: obsolete function.
Solution:   Remove the function. (Ola Söder, closes vim/vim#7374)
vim/vim@d653293

vim-patch:8.2.2054: Amiga: FEAT_ARP defined when it should not

Problem:    Amiga: FEAT_ARP defined when it should not.
Solution:   Adjust "||" to "&&" in #ifdef. (Ola Söder, closes vim/vim#7375)
vim/vim@d49a35a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brammool @meithecatte