-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update terminal Visual #13940
Update terminal Visual #13940
Conversation
1. Use `ctermbg=Grey ctermfg=Black` for both dark and light This uniforms Visual highlighting between default dark and light colors And should work for vim usually detecting light background for terminals with black/dark background colors. Previously used `ctermfg=White` leaks `cterm=bold` if available colors are less than 16. 2. Use `term=reverse cterm=reverse ctermbg=NONE ctermfg=NONE` for terminals reporting less than 8 colors available If the terminal has less than 8 colors, grey just doesn't work right
Screenshots with autodetected switch it to dark with autodetected switch it to dark with autodetected switch it to dark with autodetected switch it to dark with |
Here I have used one of @romainl suggestion mentioned in #13663 (comment) This visual obviously would not work if terminal background is for real light and has it as Both @romainl and @neutaaaaan also believe (I am in the same camp) something other than grayish should be used for visual (yellow? cyan?), but I will leave it for the next iterations and/or discussions. |
Thanks. |
I think it would be a better idea to work on the entire colorscheme at once, rather than attempting to fix discrete elements, knowing we're likely to modify them again later. For this reason I don't have much of an opinion on this change. |
I started that change, because it was explicitly only mentioned that Visual has a bad UX. And I thought it was only Visual. Now I am confused why you want to change other highlighting groups as well. Having said that, I believe it's a good thing to only gradually change single highlighting groups and not making a big change of several groups at once. For once, it's easier to bisect and/or revert and I like having small atomic individual changes, so we can get feedback if a single group highlighting is problematic for some use cases, although improving the whole default color scheme will then take longer. |
@chrisbra Fixing those in |
If you want to go ahead and improve other default highlighting groups, please go ahead and create a separate PR. We can discuss the UX in this more specific PR then. But I won't merge until I got a fair amount of feedback that the new defaults are good.
I don't buy that argument. We have had the default now for 20 years? And it's not exactly broken. |
That's, like… the whole purpose of the thread you linked to, over at vim/colorscheme. No one asked you to rush things out in #13663 at all and now another commit is needed to fix that hasty commit of yours. Fixing
That is not an argument, more like an observation. I wasn't there 20 years ago but I can assure you that That… and of course Vim's legendary inability to correctly set That's a lot of things to fix. For now, let's focus on what we can do for |
That wasn't rushed, it was after considering feedback I received.
Wow, thanks for your honest feedback. :( Can we please calm down a bit and keep it on a professional level? Thank you.
as far as I remember that was not easily portably possible. You cannot blame Vim for this.
Fine, I am awaiting updates then. |
Problem: Visual highlighting can still be improved Solution: Update Visual highlighting for 8 color terminals, use uniform grey highlighting for dark and light bg (Maxim Kim) Update terminal Visual 1. Use `ctermbg=Grey ctermfg=Black` for both dark and light This uniforms Visual highlighting between default dark and light colors And should work for vim usually detecting light background for terminals with black/dark background colors. Previously used `ctermfg=White` leaks `cterm=bold` if available colors are less than 16. 2. Use `term=reverse cterm=reverse ctermbg=NONE ctermfg=NONE` for terminals reporting less than 8 colors available If the terminal has less than 8 colors, grey just doesn't work right closes: vim/vim#13940 vim/vim@59bafc8 Co-authored-by: Maxim Kim <habamax@gmail.com>
Problem: Visual highlighting can still be improved Solution: Update Visual highlighting for 8 color terminals, use uniform grey highlighting for dark and light bg (Maxim Kim) Update terminal Visual 1. Use `ctermbg=Grey ctermfg=Black` for both dark and light This uniforms Visual highlighting between default dark and light colors And should work for vim usually detecting light background for terminals with black/dark background colors. Previously used `ctermfg=White` leaks `cterm=bold` if available colors are less than 16. 2. Use `term=reverse cterm=reverse ctermbg=NONE ctermfg=NONE` for terminals reporting less than 8 colors available If the terminal has less than 8 colors, grey just doesn't work right closes: vim/vim#13940 vim/vim@59bafc8 Co-authored-by: Maxim Kim <habamax@gmail.com>
ctermbg=Grey ctermfg=Black
for both dark and lightThis uniforms Visual highlighting between default dark and light colors And should work for vim usually detecting light background for terminals with black/dark background colors.
Previously used
ctermfg=White
leakscterm=bold
if available colors are less than 16.term=reverse cterm=reverse ctermbg=NONE ctermfg=NONE
for terminals reporting less than 8 colors availableIf the terminal has less than 8 colors, grey just doesn't work right