-
-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
smoothscroll may cause infinite loop #14772
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: smoothscroll may cause infinite loop, with very narrow windows (Jaehwang Jung, after v9.1.0280) Solution: Check for width1 being negative, also verify that win_linetabsize does not overflow fixes: vim#14750 Signed-off-by: Christian Brabandt <cb@256bit.org>
zeertzjq
reviewed
May 14, 2024
zeertzjq
added a commit
to zeertzjq/neovim
that referenced
this pull request
May 15, 2024
Problem: smoothscroll may cause infinite loop, with very narrow windows (Jaehwang Jung, after v9.1.0280) Solution: Check for width1 being negative, verify that win_linetabsize does not overflow fixes: vim/vim#14750 closes: vim/vim#14772 vim/vim@eff20eb Co-authored-by: Christian Brabandt <cb@256bit.org>
zeertzjq
added a commit
to zeertzjq/neovim
that referenced
this pull request
May 15, 2024
Problem: smoothscroll may cause infinite loop, with very narrow windows (Jaehwang Jung, after v9.1.0280) Solution: Check for width1 being negative, verify that win_linetabsize does not overflow fixes: vim/vim#14750 closes: vim/vim#14772 vim/vim@eff20eb Co-authored-by: Christian Brabandt <cb@256bit.org>
zeertzjq
added a commit
to zeertzjq/neovim
that referenced
this pull request
May 15, 2024
Problem: smoothscroll may cause infinite loop, with very narrow windows (Jaehwang Jung, after v9.1.0280) Solution: Check for width1 being negative, verify that win_linetabsize does not overflow fixes: vim/vim#14750 closes: vim/vim#14772 vim/vim@eff20eb Co-authored-by: Christian Brabandt <cb@256bit.org>
zeertzjq
added a commit
to neovim/neovim
that referenced
this pull request
May 15, 2024
Problem: smoothscroll may cause infinite loop, with very narrow windows (Jaehwang Jung, after v9.1.0280) Solution: Check for width1 being negative, verify that win_linetabsize does not overflow fixes: vim/vim#14750 closes: vim/vim#14772 vim/vim@eff20eb Co-authored-by: Christian Brabandt <cb@256bit.org>
icholy
pushed a commit
to icholy/neovim
that referenced
this pull request
May 17, 2024
Problem: smoothscroll may cause infinite loop, with very narrow windows (Jaehwang Jung, after v9.1.0280) Solution: Check for width1 being negative, verify that win_linetabsize does not overflow fixes: vim/vim#14750 closes: vim/vim#14772 vim/vim@eff20eb Co-authored-by: Christian Brabandt <cb@256bit.org>
huangyingw
pushed a commit
to huangyingw/neovim
that referenced
this pull request
May 31, 2024
Problem: smoothscroll may cause infinite loop, with very narrow windows (Jaehwang Jung, after v9.1.0280) Solution: Check for width1 being negative, verify that win_linetabsize does not overflow fixes: vim/vim#14750 closes: vim/vim#14772 vim/vim@eff20eb Co-authored-by: Christian Brabandt <cb@256bit.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: smoothscroll may cause infinite loop, with
very narrow windows
(Jaehwang Jung, after v9.1.0280)
Solution: Check for width1 being negative, also verify
that win_linetabsize does not overflow
fixes: #14750