Mode message for spell completion doesn't match allowed keys #15065
Conversation
Problem: Mode message for spell completion doesn't match allowed keys. Solution: Use "^S" instead of "s". fixes: neovim/neovim#29431 This matches the code in vim_is_ctrl_x_key(): case CTRL_X_SPELL: return (c == Ctrl_S || c == Ctrl_P || c == Ctrl_N);
|
thanks! |
…llowed keys
Problem: Mode message for spell completion doesn't match allowed keys
(Kyle Kovacs)
Solution: Show "^S" instead of "s".
(zeertzjq)
This matches the code in vim_is_ctrl_x_key():
case CTRL_X_SPELL:
return (c == Ctrl_S || c == Ctrl_P || c == Ctrl_N);
fixes: neovim#29431
closes: vim/vim#15065
vim/vim@7002c05
…llowed keys (#29437) Problem: Mode message for spell completion doesn't match allowed keys (Kyle Kovacs) Solution: Show "^S" instead of "s". (zeertzjq) This matches the code in vim_is_ctrl_x_key(): case CTRL_X_SPELL: return (c == Ctrl_S || c == Ctrl_P || c == Ctrl_N); fixes: #29431 closes: vim/vim#15065 vim/vim@7002c05
…llowed keys (#29437) Problem: Mode message for spell completion doesn't match allowed keys (Kyle Kovacs) Solution: Show "^S" instead of "s". (zeertzjq) This matches the code in vim_is_ctrl_x_key(): case CTRL_X_SPELL: return (c == Ctrl_S || c == Ctrl_P || c == Ctrl_N); fixes: #29431 closes: vim/vim#15065 vim/vim@7002c05 (cherry picked from commit 1db1476)
|
Thanks for the fix! However, I fear there may be a localization issue. For example, search in Now that the message has changed, I think the translations might not work properly. I'd be happy to fix it, but I don't know how this is normally handled. Would I make a PR against vim or neovim? Do vim-based neovim patches get added manually? |
I checked the commit history of src/po and it seems that translations usually don't get updated when a message changes, so I'm not sure if this should be done.
You don't need to worry about that. |
|
I see. Based on commits like this one it looks like each language and message is kind of handled individually on a case-by-base basis. So in this case, since a message changed, each individual language might eventually get its own pull request to update that message with the proper text. Until then, all of the languages will just have wrong translations for that message. Seems like it would be better to just batch update them all at once while we're here, no? Is there someone in charge of each language, or is it a community effort to keep the |
|
you could ping the translators, check the author of those po files (or the Last-Translator in the files headers). We could also re-generate the po files in a separate PR. I believe we have sometimes done it. |
|
hello @nullromo I would like to help, but really don't know how to do it! :) |
|
I went ahead and made a PR for it, just to keep things cleaner. |
Problem: Mode message for spell completion doesn't match allowed keys.
Solution: Use "^S" instead of "s".
fixes: neovim/neovim#29431
This matches the code in vim_is_ctrl_x_key():