Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove UTF8 tests that are already invoked from test_alot_utf8.vim #2369

Closed
wants to merge 2 commits into from

Conversation

yegappan
Copy link
Member

Several UTF8 related tests are already invoked from test_alot_utf8.vim.
Remove these tests from Make_all.mak.

@codecov-io
Copy link

Codecov Report

Merging #2369 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2369      +/-   ##
==========================================
+ Coverage    74.5%    74.5%   +<.01%     
==========================================
  Files          91       91              
  Lines      132397   132396       -1     
  Branches    30972    29080    -1892     
==========================================
+ Hits        98639    98642       +3     
+ Misses      33733    33725       -8     
- Partials       25       29       +4
Impacted Files Coverage Δ
src/gui.c 47.4% <0%> (-0.16%) ⬇️
src/if_py_both.h 76.45% <0%> (-0.15%) ⬇️
src/gui_gtk_x11.c 47.65% <0%> (-0.1%) ⬇️
src/channel.c 82.44% <0%> (-0.05%) ⬇️
src/window.c 81.78% <0%> (+0.03%) ⬆️
src/term.c 50.72% <0%> (+0.1%) ⬆️
src/os_unix.c 54.28% <0%> (+0.13%) ⬆️
src/if_xcmdsrv.c 84.71% <0%> (+0.17%) ⬆️
src/message.c 68.72% <0%> (+0.24%) ⬆️
src/gui_beval.c 63.09% <0%> (+0.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3679c17...d252777. Read the comment docs.

@brammool brammool closed this in 2c997d7 Nov 23, 2017
justinmk added a commit to justinmk/neovim that referenced this pull request Feb 11, 2018
Problem:    Some tests are run twice.
Solution:   Invoked most utf8 tests only from test_alot_utf8. (Yegappan
            Lakshmanan, closes vim/vim#2369)

vim/vim@2c997d7
adizero pushed a commit to adizero/vim that referenced this pull request May 19, 2018
Problem:    Some tests are run twice.
Solution:   Invoked most utf8 tests only from test_alot_utf8. (Yegappan
            Lakshmanan, closes vim#2369)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants