vim.exe to 256 colors, too #2821

ghost · 2018-04-19T03:58:05Z

Hello,

To switch to 256 colors, enter ":set t_Co=256" without the termguicolors.
To return to 16 colors, enter ":set t_Co=16".
It exists with vtp (vcon).
FEAT_TERMGUICOLORS is required.

After I wrote a 24-bit patch, I realized that I can not use the 256 color scheme https://github.com/KKPMW/moonshine-vim so I can use it.

enjoying.

codecov-io · 2018-04-19T04:15:08Z

Codecov Report

Merging #2821 into master will decrease coverage by <.01%.
The diff coverage is 81.25%.

@@            Coverage Diff             @@
##           master    #2821      +/-   ##
==========================================
- Coverage    75.4%   75.39%   -0.01%     
==========================================
  Files          92       92              
  Lines      134598   134739     +141     
==========================================
+ Hits       101490   101593     +103     
- Misses      33108    33146      +38

Impacted Files	Coverage Δ
src/misc1.c	`84.37% <100%> (+0.03%)`	⬆️
src/terminal.c	`70.67% <100%> (+0.04%)`	⬆️
src/term.c	`60.36% <100%> (-0.21%)`	⬇️
src/option.c	`84.94% <62.5%> (+0.01%)`	⬆️
src/os_unix.c	`54.48% <0%> (-0.66%)`	⬇️
src/buffer.c	`77.8% <0%> (-0.37%)`	⬇️
src/message.c	`74.59% <0%> (-0.25%)`	⬇️
src/ex_cmds2.c	`78.62% <0%> (-0.08%)`	⬇️
src/ex_docmd.c	`75.8% <0%> (-0.06%)`	⬇️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 285e335...9c78c4d. Read the comment docs.

brammool · 2018-04-19T20:24:44Z

Nobuhiro Takasaki wrote:

To switch to 256 colors, enter ":set t_Co=256" without the termguicolors. To return to 16 colors, enter ":set t_Co=16". It exists with vtp (vcon). FEAT_TERMGUICOLORS is required. After I wrote a 24-bit patch, I realized that I can not use the 256 color scheme https://github.com/KKPMW/moonshine-vim so I can use it. enjoying.

Thanks for looking into this. It looks like the color tables are the same as what is used in terminal.c. They should be moved to a common place, probably globals.h. It should be possible to use an enum for curr_mode. Have some users tried this out?

…

-- hundred-and-one symptoms of being an internet addict: 234. You started college as a chemistry major, and walk out four years later as an Internet provider. /// Bram Moolenaar -- Bram@Moolenaar.net -- http://www.Moolenaar.net \\\ /// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\ \\\ an exciting new programming language -- http://www.Zimbu.org /// \\\ help me help AIDS victims -- http://ICCF-Holland.org ///

k-takata · 2018-04-20T05:20:26Z

src/globals.h

+#endif
+;
+
+extern int grey_ramp[]


Shouldn't be EXTERN instead of extern?

ghost · 2018-04-20T06:15:23Z

Only I did the test.
Others have not tested.
I will ask many different people.

ghost · 2018-04-21T12:26:35Z

I do not have any friends in the test...

janlazo · 2018-04-25T05:33:36Z

Is tgc still no-op on Windows without +vcon? I was using set tgc with set term=xterm t_Co=256 on ConEmu to get true colors but I'm back to 256 colors after patch 8.0.1531.

ghost · 2018-04-25T06:16:48Z

I just got to know ConEmu. I will look at ConEmu from now.
I have not tested in an environment that is not :set term=win32.

ghost · 2018-04-25T06:35:04Z

I have seen ConEmu now.
I feel that it is not straightforward. Please wait for a couple of days as I will test again.

janlazo · 2018-04-25T08:11:32Z

I check value of $ConEmuANSI and check if using GVim or terminal. winpty doesn't unset ConEmu environment variables so I unset $ConEmuANSI in GUIs so that I can use terminal Vim in GVim's :terminal.
https://github.com/janlazo/dotvim8/blob/master/shared.vim#L385-L397

For tgc, I check Vim 8 patches for truecolor support and +vcon. I added additional checks because I had screen issues on tmux or when &t_Co <= 16.
https://github.com/janlazo/dotvim8/blob/master/shared.vim#L424-L445

ghost · 2018-04-25T17:34:22Z

Thank you for the example.
I returned the patch to 8.0.1530 and confirmed the behavior.
I think I got it fixed.

janlazo · 2018-04-25T20:00:43Z

Is TERM=cygwin supported so the user can run terminal Vim on msys2 sh/bash? I use ConEmu for sh/bash as well instead of mintty.

ghost · 2018-04-26T15:06:30Z

With the above fix, TERM=cygwin should also work as expected.
If it is not as expected, please contact here again.

janlazo · 2018-04-26T22:07:29Z

I had issues using 256 colors (with or without tgc) for Vim within :terminal so I updated my vimrc to use 256 colors for Vim outside of :terminal. This happens in the default Vim distributed with msys2/mingw. Not sure if it's Vim or ConEmu bug but feel free to optimize or simplify the code if it helps.

k-takata · 2018-04-27T03:05:53Z

256 colors cannot be used within :terminal (in Win32 version of Vim) because of limitation of Win32 API.
:terminal uses winpty to capture the output of the executed command, and winpty uses Win32 API to capture that. However, Win32 API doesn't provide a way to capture 256 colors (or more).
(This doesn't apply to Cygwin/MSYS2 versions of Vim.)

ghost · 2018-04-27T06:33:28Z

This PR is to use 256 colors with "Vim.Win32" with cmd.exe.
However, :terminal in "Vim.Win32" can use 16 index colors with winpty and Win32 API restrictions.
This should have been announced.

With vcon patch (8.0.1531), there was a possibility that I broke the operation before that. It rewrote with the previous commit.
I modified only term=win32. Other term= is no touch

I would like to make it simple, too. It will be discussed again on another occasion.

brammool · 2018-05-01T14:02:18Z

Note that, although I included the code change, it would still be nice to have an explanation in the help about how this all works.

janlazo · 2018-05-05T17:54:15Z

@ntak I cannot set tgc. I get error message E954: 24-bit colors are not supported on this environment: tgc. I'm still stuck with 256 colors. Can you remove this error message and just let the user set it?

VIM - Vi IMproved 8.0 (2016 Sep 12, compiled May  4 2018 22:03:03)
MS-Windows 64-bit console version
Included patches: 1-1790
Compiled by appveyor@APPVYR-WIN
Huge version without GUI.  Features included (+) or not (-):
+acl                +eval               -mouseshape         -tag_any_white
+arabic             +ex_extra           +multi_byte_ime/dyn +tcl/dyn
+autocmd            +extra_search       +multi_lang         +termguicolors
+autoservername     +farsi              +mzscheme/dyn       +terminal
-balloon_eval       +file_in_path       -netbeans_intg      -tgetent
+balloon_eval_term  +find_in_path       +num64              -termresponse
-browse             +float              +packages           +textobjects
++builtin_terms     +folding            +path_extra         +timers
+byte_offset        -footer             +perl/dyn           +title
+channel            +gettext/dyn        +persistent_undo    -toolbar
+cindent            -hangul_input       -postscript         +user_commands
+clientserver       +iconv/dyn          +printer            +vertsplit
+clipboard          +insert_expand      +profile            +virtualedit
+cmdline_compl      +job                +python/dyn         +visual
+cmdline_hist       +jumplist           +python3/dyn        +visualextra
+cmdline_info       +keymap             +quickfix           +viminfo
+comments           +lambda             +reltime            +vreplace
+conceal            +langmap            +rightleft          +vtp
+cryptv             +libcall            +ruby/dyn           +wildignore
+cscope             +linebreak          +scrollbind         +wildmenu
+cursorbind         +lispindent         +signs              +windows
+cursorshape        +listcmds           +smartindent        +writebackup
+dialog_con         +localmap           +startuptime        -xfontset
+diff               +lua/dyn            +statusline         -xim
+digraphs           +menu               -sun_workshop       -xpm_w32
-dnd                +mksession          +syntax             -xterm_save
-ebcdic             +modify_fname       +tag_binary         
+emacs_tags         +mouse              +tag_old_static     
   system vimrc file: "$VIM\vimrc"
     user vimrc file: "$HOME\_vimrc"
 2nd user vimrc file: "$HOME\vimfiles\vimrc"
 3rd user vimrc file: "$VIM\_vimrc"
      user exrc file: "$HOME\_exrc"
  2nd user exrc file: "$VIM\_exrc"
       defaults file: "$VIMRUNTIME\defaults.vim"
Compilation: cl -c /W3 /nologo  -I. -Iproto -DHAVE_PATHDEF -DWIN32  -DFEAT_CSCOPE -DFEAT_TERMINAL  -DFEAT_JOB_CHANNEL      -DWINVER=0x0501 -D_WIN32_WINNT=0x0501 /MP -DHAVE_STDINT_H /Ox /GL -DNDEBUG  /Zl /MT -DFEAT_MBYTE_IME -DDYNAMIC_IME -DFEAT_MBYTE -DDYNAMIC_ICONV -DDYNAMIC_GETTEXT -DFEAT_TCL -DDYNAMIC_TCL -DDYNAMIC_TCL_DLL=\"tcl86t.dll\" -DDYNAMIC_TCL_VER=\"8.6\" -DFEAT_LUA -DDYNAMIC_LUA -DDYNAMIC_LUA_DLL=\"lua53.dll\" -DFEAT_PYTHON -DDYNAMIC_PYTHON -DDYNAMIC_PYTHON_DLL=\"python27.dll\" -DFEAT_PYTHON3 -DDYNAMIC_PYTHON3 -DDYNAMIC_PYTHON3_DLL=\"python36.dll\" -DFEAT_MZSCHEME -I "C:\Program Files\Racket\include" -DMZ_PRECISE_GC -DDYNAMIC_MZSCHEME -DDYNAMIC_MZSCH_DLL=\"libracket3m_a36fs8.dll\" -DDYNAMIC_MZGC_DLL=\"libracket3m_a36fs8.dll\" -DFEAT_PERL -DPERL_IMPLICIT_CONTEXT -DPERL_IMPLICIT_SYS -DDYNAMIC_PERL -DDYNAMIC_PERL_DLL=\"perl524.dll\" -DFEAT_RUBY -DDYNAMIC_RUBY -DDYNAMIC_RUBY_VER=24 -DDYNAMIC_RUBY_DLL=\"x64-msvcrt-ruby240.dll\" -DFEAT_HUGE /Fd.\ObjCULYHTRZAMD64/ /Zi
Linking: link  /nologo /subsystem:console,5.02 /opt:ref /LTCG:STATUS oldnames.lib kernel32.lib advapi32.lib shell32.lib gdi32.lib  comdlg32.lib ole32.lib uuid.lib /machine:AMD64   libcmt.lib  user32.lib  /nodefaultlib:lua53.lib  /STACK:8388608  /nodefaultlib:python27.lib /nodefaultlib:python36.lib   "C:\Tcl\lib\tclstub86.lib" WSock32.lib /PDB:vim.pdb -debug

janlazo · 2018-05-07T17:38:10Z

@k-takata Does tgc on cygwin/msys2 releases of Vim depend on mintty terminal and TERM=xterm? I'd like to use ConEmu for those releases as well, similar to native Windows release prior to patch-8.0.1531

ghost · 2018-05-08T01:43:22Z

The current tgc can only be used in Windows 10.
I will send PR to use in xterm.
It is my skill that I cannot solve it once. I am sorry.

ghost · 2018-05-08T03:00:21Z

PR: #2883

Problem: Cannot use 256 colors in a MS-Windows console. Solution: Add 256 color support. (Nobuhiro Takasaki, closes vim#2821)

256 colors supported

335262d

Nobuhiro Takasaki added 2 commits April 20, 2018 12:29

Move colors to globals.h

8a55350

Convert numbers to enum

be2775e

k-takata reviewed Apr 20, 2018

View reviewed changes

Fix important mistakes

c643ee6

ConEmu supported

446f040

Suppress warnings

9c78c4d

k-takata added the platform-windows label Apr 27, 2018

chrisbra mentioned this pull request Apr 27, 2018

Add lgtm.yml file to prevent lgtm.com parsing tutor.es as ECMAScript #2844

Closed

brammool closed this in c5cd885 May 1, 2018

adizero pushed a commit to adizero/vim that referenced this pull request May 19, 2018

patch 8.0.1783: cannot use 256 colors in a MS-Windows console

3f87f96

Problem: Cannot use 256 colors in a MS-Windows console. Solution: Add 256 color support. (Nobuhiro Takasaki, closes vim#2821)

ghost deleted the vtp2 branch September 28, 2018 06:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

vim.exe to 256 colors, too #2821

vim.exe to 256 colors, too #2821

ghost commented Apr 19, 2018

codecov-io commented Apr 19, 2018 •

edited

Loading

brammool commented Apr 19, 2018 via email

k-takata Apr 20, 2018

ghost Apr 20, 2018

ghost commented Apr 20, 2018

ghost commented Apr 21, 2018

janlazo commented Apr 25, 2018 •

edited

Loading

ghost commented Apr 25, 2018 •

edited by ghost

Loading

ghost commented Apr 25, 2018 •

edited by ghost

Loading

janlazo commented Apr 25, 2018 •

edited

Loading

ghost commented Apr 25, 2018 •

edited by ghost

Loading

janlazo commented Apr 25, 2018 •

edited

Loading

ghost commented Apr 26, 2018

janlazo commented Apr 26, 2018

k-takata commented Apr 27, 2018 •

edited

Loading

ghost commented Apr 27, 2018 •

edited by ghost

Loading

brammool commented May 1, 2018

janlazo commented May 5, 2018 •

edited

Loading

janlazo commented May 7, 2018 •

edited

Loading

ghost commented May 8, 2018

ghost commented May 8, 2018

vim.exe to 256 colors, too #2821

vim.exe to 256 colors, too #2821

Conversation

ghost commented Apr 19, 2018

codecov-io commented Apr 19, 2018 • edited Loading

Codecov Report

brammool commented Apr 19, 2018 via email

k-takata Apr 20, 2018

Choose a reason for hiding this comment

ghost Apr 20, 2018

Choose a reason for hiding this comment

ghost commented Apr 20, 2018

ghost commented Apr 21, 2018

janlazo commented Apr 25, 2018 • edited Loading

ghost commented Apr 25, 2018 • edited by ghost Loading

ghost commented Apr 25, 2018 • edited by ghost Loading

janlazo commented Apr 25, 2018 • edited Loading

ghost commented Apr 25, 2018 • edited by ghost Loading

janlazo commented Apr 25, 2018 • edited Loading

ghost commented Apr 26, 2018

janlazo commented Apr 26, 2018

k-takata commented Apr 27, 2018 • edited Loading

ghost commented Apr 27, 2018 • edited by ghost Loading

brammool commented May 1, 2018

janlazo commented May 5, 2018 • edited Loading

janlazo commented May 7, 2018 • edited Loading

ghost commented May 8, 2018

ghost commented May 8, 2018

codecov-io commented Apr 19, 2018 •

edited

Loading

janlazo commented Apr 25, 2018 •

edited

Loading

ghost commented Apr 25, 2018 •

edited by ghost

Loading

ghost commented Apr 25, 2018 •

edited by ghost

Loading

janlazo commented Apr 25, 2018 •

edited

Loading

ghost commented Apr 25, 2018 •

edited by ghost

Loading

janlazo commented Apr 25, 2018 •

edited

Loading

k-takata commented Apr 27, 2018 •

edited

Loading

ghost commented Apr 27, 2018 •

edited by ghost

Loading

janlazo commented May 5, 2018 •

edited

Loading

janlazo commented May 7, 2018 •

edited

Loading