Make emsg() take variable arguments

[ichizok]

I think current emsg() family is complicated.
i.e. emsg(), emsg2(), emsg3(), emsgn(), iemsg(), iemsg2(), iemsg()

This patch proposes to add emsgf() and iemsgf() which takes printf-like variable arguments,
and remain emsg() and iemsg() since they can omit formatting strings.

[codecov-io]

Codecov Report

Merging #3302 into master will decrease coverage by 0.06%.
The diff coverage is 37.51%.

@@            Coverage Diff             @@
##           master    #3302      +/-   ##
==========================================
- Coverage   78.47%   78.41%   -0.07%     
==========================================
  Files         103      103              
  Lines      141822   141882      +60     
==========================================
- Hits       111298   111254      -44     
- Misses      30524    30628     +104

Impacted Files	Coverage Δ
src/if_ruby.c	90.29% <ø> (ø)	⬆️
src/if_tcl.c	86.42% <ø> (ø)	⬆️
src/if_lua.c	85.33% <ø> (ø)	⬆️
src/mbyte.c	62.93% <ø> (ø)	⬆️
src/regexp.c	84.53% <ø> (ø)	⬆️
src/gui_gtk_x11.c	48.03% <0%> (-0.25%)	⬇️
src/hardcopy.c	65.85% <0%> (-0.49%)	⬇️
src/ex_getln.c	76.09% <0%> (ø)	⬆️
src/misc1.c	84.49% <0%> (ø)	⬆️
src/main.c	65.2% <0%> (ø)	⬆️
... and 55 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c8b8bb...33744ae. Read the comment docs.

[brammool]

Ozaki Kiichi wrote:

I think current `emsg()` family is complicated. i.e. emsg(), emsg2(), emsg3(), emsgn(), iemsg(), iemsg2(), iemsg() This patch proposes to add `emsgf()` and `iemsgf()` which takes printf-like variable arguments, and remain `emsg()` and `iemsg()` since they can omit formatting strings.

Thanks, it's in line with smsg(). I think we should be able to get rid of EMSG2(), EMSG3() and EMSGN(). Avoids some char_u/char casts and clearer how it works.

…

-- I just planted an Algebra tree. It has square roots. /// Bram Moolenaar -- Bram@Moolenaar.net -- http://www.Moolenaar.net \\\ /// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\ \\\ an exciting new programming language -- http://www.Zimbu.org /// \\\ help me help AIDS victims -- http://ICCF-Holland.org ///

[ichizok]

Updated patch.

• Replace/Rename:

  • emsg() -> emsg1() (1 argument)
  • emsg2(), emsg3(), emsgn() -> emsg() (variable arguments)
    (also iemsg() family)

• Remove EMSG macro, use emsg() directly

[brammool]

Ozaki Kiichi wrote:

Updated patch. * Replace/Rename: * `emsg()` -> `emsg1()` (1 argument) * `emsg2()`, `emsg3()`, `emsgn()` -> `emsg()` (variable arguments) (also `iemsg()` family) * Remove `EMSG` macro, use `emsg()` directly

For consistency with msg() / smsg() we would have emsg() just take one "char_u" argument and not use IObuff. And have semsg() use variable arguments and build the message in IObuff.

…

-- hundred-and-one symptoms of being an internet addict: 146. You experience ACTUAL physical withdrawal symptoms when away from your 'puter and the net. /// Bram Moolenaar -- Bram@Moolenaar.net -- http://www.Moolenaar.net \\\ /// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\ \\\ an exciting new programming language -- http://www.Zimbu.org /// \\\ help me help AIDS victims -- http://ICCF-Holland.org ///

[ichizok]

Updated patch:

• Rename: emsg2() / emsg3() / emsgn() -> semsg(),
  also iemsgX() -> siemsg()

[brammool]

Updated patch: * Rename: emsg2() / emsg3() / emsgn() -> semsg(), also iemsgX() -> siemsg()

Thanks. Now that we are changing this, it's a good time to make it consistent. Since semsg() takes a "char *" argument, it's weird that smsg() takes a "char_u *" argument. While in most places we need a type cast. How about making all the emsg() variants take a "char *" argument? I guess only few type casts are needed then. If not, then keeping EMSG() as a macro for emsg() with the (char_u *) type cast would be useful.

…

-- hundred-and-one symptoms of being an internet addict: 153. You find yourself staring at your "inbox" waiting for new e-mail to arrive. /// Bram Moolenaar -- Bram@Moolenaar.net -- http://www.Moolenaar.net \\\ /// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\ \\\ an exciting new programming language -- http://www.Zimbu.org /// \\\ help me help AIDS victims -- http://ICCF-Holland.org ///

[ichizok]

Updated patch:

• Use macro EMSG/IEMSG

Since semsg() takes a "char *" argument, it's weird that
smsg() takes a "char_u *" argument. While in most places we need a type
cast.

I intended to make consistency with the prototype of msg(). Will it be better to use "char *"?

[brammool]

Updated patch: * Use macro `EMSG`/`IEMSG` > Since semsg() takes a "char *" argument, it's weird that smsg() takes a "char_u *" argument. While in most places we need a type cast. I intended to make consistency with the prototype of msg(). Will it be better to use "char *"?

When I grep for "smsg" I see that nearly all the calls have a type cast to (char_u *). Let's change smsg() to use a "char *" argument and also use that for semsg(). For msg() and emsg() we can use the macros. But it's probably better to make these use "char *" as well, both for consistency and to avoid the need for the macros.

…

-- Wizards had always known that the act of observation changed the thing that was observed, and sometimes forgot that it also changed the observer too. Terry Pratchett - Interesting times /// Bram Moolenaar -- Bram@Moolenaar.net -- http://www.Moolenaar.net \\\ /// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\ \\\ an exciting new programming language -- http://www.Zimbu.org /// \\\ help me help AIDS victims -- http://ICCF-Holland.org ///

[ichizok]

Currently emsg() takes the argument "char_u *" variable or string literal ("const char *"), so using "char *" argument needs always type cast. Therefore should take "const char *" argument.
But when using "const char *" argument, still need type-cast "const char *" for "char_u *" variable.

[ichizok]

Additionally: I changed the type of smsg() 1st argument to "const char *"

[ichizok]

When making emsg() (and msg()) take "const char *" argument, in their procedures some functions take "char_u *" argument so needs type-cast, a bit complicated.