Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recognise files like "DEBIAN/control" as debcontrol #6208

Closed
wants to merge 1 commit into from

Conversation

sersorrel
Copy link

It's possible for such a control file to be located at DEBIAN/control (see e.g. https://www.debian.org/doc/debian-policy/ch-controlfields.html#binary-package-control-files-debian-control), but previously Vim wasn't aware of this fact.

@codecov
Copy link

codecov bot commented Jun 5, 2020

Codecov Report

Merging #6208 into master will increase coverage by 5.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6208      +/-   ##
==========================================
+ Coverage   82.36%   87.38%   +5.01%     
==========================================
  Files         134      143       +9     
  Lines      147607   157860   +10253     
==========================================
+ Hits       121578   137946   +16368     
+ Misses      26029    19914    -6115     
Impacted Files Coverage Δ
src/libvterm/src/unicode.c 70.83% <0.00%> (-18.30%) ⬇️
src/libvterm/src/pen.c 84.66% <0.00%> (-6.36%) ⬇️
src/libvterm/src/vterm.c 66.66% <0.00%> (-5.18%) ⬇️
src/arabic.c 95.65% <0.00%> (-1.91%) ⬇️
src/libvterm/src/encoding.c 74.25% <0.00%> (-1.79%) ⬇️
src/gui_beval.c 61.63% <0.00%> (-1.73%) ⬇️
src/if_ruby.c 89.55% <0.00%> (-1.68%) ⬇️
src/profiler.c 93.03% <0.00%> (-1.65%) ⬇️
src/viminfo.c 88.72% <0.00%> (-1.50%) ⬇️
src/if_python.c 74.73% <0.00%> (-1.33%) ⬇️
... and 124 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a27655e...46b7e89. Read the comment docs.

@jamessan
Copy link
Contributor

jamessan commented Jun 5, 2020

It's possible for such a control file to be located at DEBIAN/control

debcontrol.vim is intended to highlight source package control files. While there is a fair bit of overlap between source package control files, binary package control files, and source control files, they are different formats.

I suppose the binary package and source package are close enough that they can use the same filetype, but I would need to think about whether there's a good way to highlight the distinct fields only in the respective files.

@cvwillegen
Copy link
Contributor

Having the file type detection logic looks sane. We can always add a way to make the content highlight differently later.

You will need to diff with the latest master before this can be merged.

LGTM

@yegappan yegappan added this to the vim-9.1 milestone Aug 14, 2023
@yegappan
Copy link
Member

Can you update and rebase this PR to the latest?

@chrisbra
Copy link
Member

@jamessan do you ACK?

@sersorrel
Copy link
Author

sorry, I'm not in a position to update or test this against current vim. if anyone else wants this change, feel free to do so, though.

@chrisbra
Copy link
Member

closing then for now.

@chrisbra chrisbra closed this Aug 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants