Change Pallets-Sphinx-Themes dependency to the latest commit #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Version 1.2.2 had a small issue with Python 3.8 See: pallets/pallets-sphinx-themes#27
|
Awesome, thanks! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edit: Upstream was very quick to push the fix, so updated this PR
There is an exception [1] if you try to executemake htmlin thedocsdirectory if you're using Python 3.8. This was addressed in the
Pallets-Sphinx-Themes repo but there has been no release since then.
Temporarily depend on the latest commit instead of PyPI version.
See: pallets/pallets-sphinx-themes@706ed73[1]:Exception occurred:File "/home/alex/Code/pyenv/versions/3.8.0/lib/python3.8/importlib/metadata.py", line 381, in find_distributions
found = cls._search_paths(context.pattern, context.path)
AttributeError: 'str' object has no attribute 'pattern'
The full traceback has been saved in /tmp/sphinx-err-5ejlxhto.log, if you want to report the issue to the developers.
Please also report this if it was a user error, so that a better error message can be provided next time.
A bug report can be filed in the tracker at https://github.com/sphinx-doc/sphinx/issues. Thanks!
make: *** [Makefile:53: html] Error 2