Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update filter radio button display #435

Merged
merged 1 commit into from
Nov 13, 2021
Merged

feat: Update filter radio button display #435

merged 1 commit into from
Nov 13, 2021

Conversation

reobin
Copy link
Member

@reobin reobin commented Nov 13, 2021

Type of PR

  • Feature
  • Bug Fix
  • Refactor
  • Optimization
  • Documentation update
  • Tests

Description

Display an actual icon for the filter radio button display.

Related issue

The other visual was not ideal as it glitched on some browsers.

QA Instructions

  1. Start the app
  2. Use the filter radio buttons

Added tests?

  • unit tests
  • E2E tests
  • no, because they aren't needed
  • no, because I need help

Added documentation?

  • JSDoc
  • docs.vimcolorschemes.com (./docs)
  • README
  • no

@vercel
Copy link

vercel bot commented Nov 13, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/reobin/vimcolorschemes/4kt6CTq1N41LoYb1N42hqMu23wWN
✅ Preview: https://vimcolorschemes-git-feat-radio-icon-reobin.vercel.app

@reobin reobin merged commit 8b272db into main Nov 13, 2021
@reobin reobin deleted the feat/radio-icon branch November 13, 2021 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant