Simplify common-case setup #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergiosalvatore
approved these changes
May 15, 2020
sachinagada
approved these changes
May 15, 2020
ez/ez.go
Outdated
| } | ||
|
|
||
| // YAMLConfigFlagEnv takes advantage of the ConfigWithConfigPath cfg. | ||
| func YAMLConfigFlagEnv(ctx context.Context, cfg ConfigWithConfigPath, watch bool) (*dials.Dials, error) { |
There was a problem hiding this comment.
Could we pass the decoder as a parameter here (and in fileSource) so this can be applied to all JSON, YAML, and TOML? Or should we provide another function called JSONConfigFlagEnv if we want to keep the interface simple?
There was a problem hiding this comment.
I think we can do all of the above.
The point of this subpackage is to make it easy.
Given the amount of code in this function, it's worthwhile factoring out most of it and providing a YAML wrapper, a JSON wrapper, etc.
I've rejigged this package a bit and renamed the functions to match the actual stack-order.
sachinagada
approved these changes
May 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two changes:
NewWatchingSourceconstructor variadic optionsezsubpackage with a wrapper for creating a flag source, file source and env source and appropriately using theblanksource for picking the appropriate configuration file to read.If the new function is considered simple enough, we can add a few more "simple" functions to the
ezpackage. (note: this has to be its own subpackage because of circular dependencies involving theSourceinterface, otherwise).