pflag option in ez package #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfinkel
reviewed
Aug 7, 2020
ez/ez.go
Outdated
Comment on lines
109
to
112
| var flagSrc dials.Source | ||
| if option.flagSubstitute != nil { | ||
| flagSrc = option.flagSubstitute | ||
| } else { |
There was a problem hiding this comment.
Let's initialize flagSrc directly with option.flagSubstitute, the current else block just becomes if flagSrc == nil { ...
There was a problem hiding this comment.
Oh I like this a lot better. Thank you!
dfinkel
approved these changes
Aug 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a pflag specific option in the ez package. The implementation is general so we can substitute any sources for the flag package and add more source options in the future