dials/blank: Add/use BlockingReportNewValue #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfinkel
force-pushed
the
robust_blank
branch
2 times, most recently
from
a9195fa
to
329b471
Compare
Blank has been almost impossible to use correctly, with only a few (constrained) cases where it can be used safely without having terrible races (hence the complexity in the `ez` package wrapping it). Fix this by adding a BlockingReportNewValue method to the `WatchArgs` interface that returns any errors in stacking or validation to the caller, (and returns successfully if the new config has been successfully installed)
With the last few changes, the building-blocks which ez is wrapping and/or working with are much more robust and easier to use. Update ez to reflect this new state: - eliminate the extra channels now that Blank blocks and returns errors. - register the OnNewConfig callback at the end, just before returning. - rename `p` to `dp` to eliminate some confusion with `params`
sergiosalvatore
approved these changes
Jul 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blank has been almost impossible to use correctly, with only a few
(constrained) cases where it can be used safely without having terrible
races (hence the complexity in the
ezpackage wrapping it).Fix this by adding a BlockingReportNewValue method to the
WatchArgsinterface that returns any errors in stacking or validation to the
caller, (and returns successfully if the new config has been
successfully installed)
ez: simplify impl with blank fixes, cbs & generics
With the last few changes, the building-blocks which ez is wrapping
and/or working with are much more robust and easier to use.
Update ez to reflect this new state:
errors.
ptodpto eliminate some confusion withparams