Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom unit conversions #115

Closed
offlinehacker opened this issue May 26, 2014 · 5 comments
Closed

Custom unit conversions #115

offlinehacker opened this issue May 26, 2014 · 5 comments

Comments

@offlinehacker
Copy link

What would be the best way to add custom unit conversions. I want to convert some financial data from unit to unit. I assume unit conversion plugin support should be integrated?

@Dieterbe
Copy link
Contributor

normally you should be able to just use metrics with a custom unit.
let's say you add a metric with unit=OfflineHack, you can now query for unit=MOfflineHack, unit=GiOfflineHack/h, etc

@offlinehacker
Copy link
Author

I would like to covert for example usd to eur where i would be able to
write custom conversion plugin. Support for that would make this app really
awesome :)
On May 26, 2014 6:05 PM, "Dieter Plaetinck" notifications@github.com
wrote:

normally you should be able to just use metrics with a custom unit.
let's say you add a metric with unit=OfflineHack, you can now query for
unit=MOfflineHack, unit=GiOfflineHack/h, etc


Reply to this email directly or view it on GitHubhttps://github.com//issues/115#issuecomment-44201032
.

@Dieterbe
Copy link
Contributor

ah you want to convert between currencies. do you want to hardcode the currency conversion rate? what if it changes?

@offlinehacker
Copy link
Author

That would be up to conversion plugin to retrieve conversion rate.
On May 26, 2014 6:53 PM, "Dieter Plaetinck" notifications@github.com
wrote:

ah you want to convert between currencies. do you want to hardcode the
currency conversion rate? what if it changes?


Reply to this email directly or view it on GitHubhttps://github.com//issues/115#issuecomment-44204183
.

@Dieterbe
Copy link
Contributor

Dieterbe commented Aug 8, 2014

currently unit conversions are in the code base, not as plugins.
if you want this, you can either code it in the app, or refactor it to have plugin unit conversions.

but you're the only one asking for this so doing it as plugins might be overkill, unless you find an easy way

@Dieterbe Dieterbe closed this as completed Sep 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants