Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update codecov.yml #774

Merged
merged 6 commits into from Oct 19, 2021
Merged

Update codecov.yml #774

merged 6 commits into from Oct 19, 2021

Conversation

fisherinnovation
Copy link
Contributor

@fisherinnovation fisherinnovation commented Oct 19, 2021

Readds inline commenting and appends thresholds to kick things off again.

@fisherinnovation fisherinnovation self-assigned this Oct 19, 2021
@codecov
Copy link

codecov bot commented Oct 19, 2021

Codecov Report

Merging #774 (dd11b8e) into master (0ec47da) will decrease coverage by 0.81%.
The diff coverage is 25.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #774      +/-   ##
==========================================
- Coverage   79.51%   78.69%   -0.82%     
==========================================
  Files           6        6              
  Lines         410      413       +3     
==========================================
- Hits          326      325       -1     
- Misses         84       88       +4     
Impacted Files Coverage Δ
src/lib/embed.js 69.23% <ø> (-2.57%) ⬇️
src/player.js 70.29% <25.00%> (-0.56%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96abf1d...dd11b8e. Read the comment docs.

Copy link
Contributor

@jdreetz jdreetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fisherinnovation fisherinnovation merged commit bf603a6 into master Oct 19, 2021
@fisherinnovation fisherinnovation deleted the codecov-config branch October 19, 2021 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants