Always be cloning

vimeo · Apr 3, 2020 · 08594cf · 08594cf
1 parent b340f2b
commit 08594cf
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/Psalm/Internal/Analyzer/FunctionLike/ReturnTypeCollector.php b/src/Psalm/Internal/Analyzer/FunctionLike/ReturnTypeCollector.php
@@ -328,7 +328,7 @@ protected static function getYieldTypeFromExpression(
                 $generator_type = new Atomic\TGenericObject(
                     'Generator',
                     [
-                        $key_type ?: Type::getInt(),
+                        $key_type ? clone $key_type : Type::getInt(),
                         clone $value_type,
                         Type::getMixed(),
                         Type::getMixed()

diff --git a/src/Psalm/Internal/Analyzer/Statements/ExpressionAnalyzer.php b/src/Psalm/Internal/Analyzer/Statements/ExpressionAnalyzer.php
@@ -1933,7 +1933,7 @@ protected static function analyzeYield(
                     if ($expression_atomic_type instanceof Type\Atomic\TGenericObject) {
                         $yield_type = PropertyFetchAnalyzer::localizePropertyType(
                             $codebase,
-                            $yield_type,
+                            clone $yield_type,
                             $expression_atomic_type,
                             $classlike_storage,
                             $classlike_storage