Allow unset of potentially invalid array key type

vimeo · Aug 18, 2019 · 1b983ba · 1b983ba
1 parent 9d62971
commit 1b983ba
Showing 1 changed file with 11 additions and 9 deletions.
diff --git a/src/Psalm/Internal/Analyzer/Statements/Expression/Fetch/ArrayFetchAnalyzer.php b/src/Psalm/Internal/Analyzer/Statements/Expression/Fetch/ArrayFetchAnalyzer.php
@@ -1023,15 +1023,17 @@ public static function getArrayAccessTypeGivenOffset(
                 if ($has_valid_offset && $context->inside_isset) {
                     // do nothing
                 } elseif ($has_valid_offset) {
-                    if (IssueBuffer::accepts(
-                        new PossiblyInvalidArrayOffset(
-                            'Cannot access value on variable ' . $array_var_id . ' ' . $used_offset
-                                . ', expecting ' . $invalid_offset_type,
-                            new CodeLocation($statements_analyzer->getSource(), $stmt)
-                        ),
-                        $statements_analyzer->getSuppressedIssues()
-                    )) {
-                        // fall through
+                    if (!$context->inside_unset) {
+                        if (IssueBuffer::accepts(
+                            new PossiblyInvalidArrayOffset(
+                                'Cannot access value on variable ' . $array_var_id . ' ' . $used_offset
+                                    . ', expecting ' . $invalid_offset_type,
+                                new CodeLocation($statements_analyzer->getSource(), $stmt)
+                            ),
+                            $statements_analyzer->getSuppressedIssues()
+                        )) {
+                            // fall through
+                        }
                     }
                 } else {
                     if (IssueBuffer::accepts(