Fix undefined numeric offset

vimeo · Oct 1, 2019 · 2ffdf1b · 2ffdf1b
1 parent f8a2eae
commit 2ffdf1b
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/src/Psalm/Internal/Analyzer/Statements/Expression/CallAnalyzer.php b/src/Psalm/Internal/Analyzer/Statements/Expression/CallAnalyzer.php
@@ -353,7 +353,10 @@ protected static function checkFunctionArguments(
             : null;
 
         // if this modifies the array type based on further args
-        if ($method_id && in_array($method_id, ['array_push', 'array_unshift'], true) && $function_params) {
+        if ($method_id && in_array($method_id, ['array_push', 'array_unshift'], true)
+            && $function_params
+            && $args
+        ) {
             if (self::handleArrayAddition($statements_analyzer, $args, $context) === false) {
                 return false;
             }

diff --git a/tests/FunctionCallTest.php b/tests/FunctionCallTest.php
@@ -2460,6 +2460,11 @@ function test() : void {
                     }',
                 'error_message' => 'TypeDoesNotContainType',
             ],
+            'noCrashOnEmptyArrayPush' => [
+                '<?php
+                    array_push();',
+                'error_message' => 'TooFewArguments',
+            ],
         ];
     }
 }