Fix #4516 - treat exit() as the empty type

vimeo · Nov 9, 2020 · 3aaa1d8 · 3aaa1d8
1 parent 683546e
commit 3aaa1d8
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 0 deletions.
diff --git a/src/Psalm/Internal/Analyzer/Statements/Expression/ExitAnalyzer.php b/src/Psalm/Internal/Analyzer/Statements/Expression/ExitAnalyzer.php
@@ -78,6 +78,8 @@ public static function analyze(
             $context->inside_call = false;
         }
 
+        $statements_analyzer->node_data->setType($stmt, \Psalm\Type::getEmpty());
+
         return true;
     }
 }
diff --git a/tests/MatchTest.php b/tests/MatchTest.php
@@ -188,6 +188,23 @@ function foo(int $i) {
                 false,
                 '8.0',
             ],
+            'exitIsLikeThrow' => [
+                '<?php
+                    /**
+                     * @param 1|2|3 $i
+                     */
+                    function foo(int $i): void {
+                        $a = match ($i) {
+                            1 => exit(),
+                            2, 3 => $i,
+                        };
+                        $a === "aaa";
+                    }',
+                'error_message' => 'DocblockTypeContradiction',
+                [],
+                false,
+                '8.0',
+            ],
         ];
     }
 }