Fix #2028 - warn when using deprecated class in function signature

vimeo · Aug 22, 2019 · 4fcbc0f · 4fcbc0f
1 parent 855ab35
commit 4fcbc0f
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 0 deletions.
diff --git a/src/Psalm/Type/Atomic/TNamedObject.php b/src/Psalm/Type/Atomic/TNamedObject.php
@@ -169,6 +169,23 @@ public function check(
             return false;
         }
 
+        if ($codebase->classlike_storage_provider->has($this->value)) {
+            $class_storage = $codebase->classlike_storage_provider->get($this->value);
+
+            if ($class_storage->deprecated) {
+                if (\Psalm\IssueBuffer::accepts(
+                    new \Psalm\Issue\DeprecatedClass(
+                        'Class ' . $this->value . ' is marked as deprecated',
+                        $code_location,
+                        $this->value
+                    ),
+                    $source->getSuppressedIssues()
+                )) {
+                    // fall through
+                }
+            }
+        }
+
         $this->checkIntersectionTypes(
             $source,
             $code_location,

diff --git a/tests/DeprecatedAnnotationTest.php b/tests/DeprecatedAnnotationTest.php
@@ -140,6 +140,16 @@ class Foo {}
                     echo Foo::class;',
                 'error_message' => 'DeprecatedClass',
             ],
+            'deprecatedClassAsParam' => [
+                '<?php
+                    /**
+                     * @deprecated
+                     */
+                    class DeprecatedClass{}
+
+                    function foo(DeprecatedClass $deprecatedClass): void {}',
+                'error_message' => 'DeprecatedClass',
+            ],
         ];
     }
 }