Fix #2170 - allow @method annotations to override inherited immutable…

… ones
vimeo · Sep 25, 2019 · 5e47cda · 5e47cda
1 parent 648dda6
commit 5e47cda
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 0 deletions.
diff --git a/src/Psalm/Internal/Analyzer/MethodAnalyzer.php b/src/Psalm/Internal/Analyzer/MethodAnalyzer.php
@@ -613,6 +613,7 @@ public static function compareMethods(
 
         if ($guide_method_storage->external_mutation_free
             && !$implementer_method_storage->external_mutation_free
+            && !$guide_method_storage->mutation_free_inferred
         ) {
             if (IssueBuffer::accepts(
                 new MissingImmutableAnnotation(

diff --git a/tests/ImmutableAnnotationTest.php b/tests/ImmutableAnnotationTest.php
@@ -219,6 +219,23 @@ public function getData(): string {
                         }
                     }'
             ],
+            'allowMethodOverriding' => [
+                '<?php
+                    class A {
+                        private string $a;
+
+                        public function __construct(string $a) {
+                            $this->a = $a;
+                        }
+
+                        public function getA() : string {
+                            return $this->a;
+                        }
+                    }
+
+                    /** @method string getA() */
+                    class B extends A {}',
+            ],
         ];
     }